Add "To Top" button to the manual sort category listing #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems great ! I'll try to have a look on this one and to test it deeply. But it's definitely a big THANKS for contributing to our Open Source project :) |
romainruaud
force-pushed
the
master
branch
2 times, most recently
from
28eb80b to
3cbc361
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How it looks:
The reason why:
I added this feature on our project because we had a lot of products in manual sort.
When you add a product as Manual sort, it gets to the end of the Manual sort product list and using the drag and drop to get a few products to the top is not really practical and can take some time, especially for a user that is not really good with a mouse.
Technical Details:
I did it and tested it in a few hours because I did not have too much time to spend on this so it might not be perfectly coded. I tried to reuse the API and logic that was currently available but the code could clearly be improved / refactored.
What's missing: