Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make HID Device a slime #1235

Merged
merged 2 commits into from
Nov 21, 2024
Merged

make HID Device a slime #1235

merged 2 commits into from
Nov 21, 2024

Conversation

sctanf
Copy link
Member

@sctanf sctanf commented Nov 11, 2024

No description provided.

@github-actions github-actions bot added the Area: GUI Related to the GUI label Nov 11, 2024
@Eirenliel
Copy link
Member

Why doesn't it read manufacturer from the usb info?

@Eirenliel
Copy link
Member

Also a PR should clearly say what the change does, why isSlime matters? I have no idea what this change means for HID devices that aren't original slimes, for example

@sctanf
Copy link
Member Author

sctanf commented Nov 11, 2024

Why doesn't it read manufacturer from the usb info?

This field is used in GUI as Type, so I used HID Device as the type. If it should be changed to manufacturer or to something else, this should be clearer

@sctanf
Copy link
Member Author

sctanf commented Nov 11, 2024

Also a PR should clearly say what the change does, why isSlime matters? I have no idea what this change means for HID devices that aren't original slimes, for example

I should have added, isSlime is how the GUI filters when you select the option to only show HMD and Slime trackers

so there is already DIY slimes or any slime made by third-party, is this an original slime? I don't know what type/manufacturer is appropriate, or if this is a wrong implementation for the intended outcome

@Eirenliel
Copy link
Member

Understandable, I moved it out into a new issue.

@ImUrX ImUrX added the Type: Bug Something isn't working label Nov 19, 2024
@Eirenliel Eirenliel merged commit 6232903 into SlimeVR:main Nov 21, 2024
13 checks passed
@ButterscotchV ButterscotchV mentioned this pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: GUI Related to the GUI Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants