Expand skeleton height config #1156

ButterscotchV · 2024-09-08T12:53:00Z

Replaces the basic height configuration that is part of AutoBone with one that includes the floor height. This value is also used when resetting proportions, so you no longer need to be in a specific pose for that.

Requires SlimeVR/SolarXR-Protocol#147.

Remaining tasks:

Handle not having positional trackers
Load current height/floor values from config
- Loaded values are valid if height - floor > 0.4
Value validation
- Values are valid if height - floor > 0.4
- Must warn user they cannot continue because the resulting height is invalid
Warn user if no height is configured when resetting proportions (default will be used)

- Make height off max and min tracker positions - Move HMD height to skeleton - Remove full height as it's never used

loucass003 · 2024-11-25T12:06:01Z

gui/src/components/commons/NumberSelector.tsx

@@ -35,7 +61,19 @@ export function NumberSelector({
        <div className="flex flex-col gap-1 w-full">
          <Typography bold>{label}</Typography>
          <div className="flex gap-5 bg-background-60 p-2 rounded-lg">
-            <div className="flex">
+            <div className="flex gap-1">


Standard gap is usually 2

yeah but gap-1 is used usually for input commons

loucass003 · 2024-11-25T12:06:05Z

gui/src/components/commons/NumberSelector.tsx

@@ -48,7 +86,7 @@ export function NumberSelector({
            <div className="flex flex-grow justify-center items-center w-10 text-standard">
              {valueLabelFormat ? valueLabelFormat(value) : value}
            </div>
-            <div className="flex">
+            <div className="flex gap-1">


Standard gap is usually 2

gui/src/components/onboarding/pages/body-proportions/AutomaticProportions.tsx

gui/src/components/onboarding/pages/body-proportions/autobone-steps/CheckHeight.tsx

gui/src/components/onboarding/pages/body-proportions/scaled-steps/ManualHeightStep.tsx

gui/src/components/onboarding/pages/body-proportions/autobone-steps/CheckFloorHeight.tsx

gui/src/components/onboarding/pages/body-proportions/scaled-steps/Done.tsx

gui/src/components/onboarding/pages/body-proportions/autobone-steps/CheckHeight.tsx

loucass003 · 2024-11-25T13:16:27Z

gui/src/components/commons/NumberSelector.tsx

@@ -35,7 +61,19 @@ export function NumberSelector({
        <div className="flex flex-col gap-1 w-full">


Standard gap is usually 2

didnt edit this

gui/src/components/onboarding/pages/body-proportions/ProportionsChoose.tsx

:c

ButterscotchV · 2024-12-19T16:04:23Z

One issue with this currently is there's no proper way to configure the user's height without going through the setup wizard or AutoBone... This is not ideal as the height is also used for resetting the proportions and there are cases where you cannot do AutoBone. We need to have the setup section available on its own in some capacity.

ImUrX · 2024-12-20T20:57:45Z

Ok, butter, i think we should stop for now on this PR and merge it, and make a new PR on refactoring how Body proportions menu looks, much better on the objective being able to adjust your height, or doing autobone or manual proportions in a more intuitive way instead of the current choose menu

ButterscotchV and others added 20 commits April 4, 2024 04:19

Base proportion limits off defaults directly

d769fa3

Change height config

b803eb3

- Make height off max and min tracker positions - Move HMD height to skeleton - Remove full height as it's never used

Reset proportions based on hmd height config

5317db0

Fix AutoBone HMD height

67e2941

Add floor height config

125f27e

Merge remote-tracking branch 'upstream/main' into height-config

cf8f6c6

Merge branch 'main' into height-config

48d330a

Merge remote-tracking branch 'upstream/main' into height-config

f5bf2e2

Update solarxr-protocol

abc534e

continue later, need to think

aded461

finish the steps

07f2f63

Merge branch 'main' into height-config

587cb97

solarxr

1b91d7f

Merge branch 'main' into height-config

bd2cfd1

continuing with height pages

95de93d

add scaled proportions step

49fd367

Don't select internal trackers for height

a1a428e

Fix floor height & crashing with no trackers

85c0199

Change defaults & fix minimum height

71d383d

Remove steps & remove timer on reset proportions

fa2d634

ButterscotchV added Priority: Normal The default priority Area: GUI Related to the GUI Type: Enhancement Adds or improves a feature Area: Translation Improvements or additions to translations Area: Server Related to the server labels Sep 8, 2024

ButterscotchV assigned ImUrX and ButterscotchV Sep 8, 2024

ButterscotchV added the Status: Blocked by other issue Progress cannot be made until linked issue is resolved label Sep 8, 2024

ButterscotchV changed the title ~~Add skeleton height config~~ Expand skeleton height config Sep 8, 2024

ButterscotchV mentioned this pull request Sep 8, 2024

Expand skeleton height config SlimeVR/SolarXR-Protocol#147

Merged

ButterscotchV requested review from Eirenliel, Erimelowo and loucass003 as code owners November 21, 2024 21:00

loucass003 requested changes Nov 25, 2024

View reviewed changes

ButterscotchV and others added 5 commits November 25, 2024 17:50

Make height measurement buttons more descriptive

e8b3825

Clarify height measurement wording

c7fc21c

Clarify height minimum wording

16d2c6b

fix reviews

9277e66

Add missing translations & re-order AutoBone steps

7527467

ButterscotchV commented Nov 30, 2024

View reviewed changes

gui/src/components/onboarding/pages/body-proportions/ProportionsChoose.tsx Show resolved Hide resolved

ButterscotchV added 2 commits November 30, 2024 04:21

Allow using loaded height config to continue

8610109

Treat "null" height config as 0 because Flatbuffer

6bc4676

:c

ButterscotchV force-pushed the height-config branch from b012dac to 6bc4676 Compare November 30, 2024 09:29

ImUrX requested a review from loucass003 December 2, 2024 18:08

ImUrX and others added 2 commits December 2, 2024 19:41

fix reset proportions triggering the export button

1b3ae81

Allow non-HMD trackers to be used for height

a041370

ButterscotchV mentioned this pull request Dec 8, 2024

Release v0.14.0 #1258

Open

Merge remote-tracking branch 'upstream/main' into height-config

fb3ac98

ImUrX and others added 5 commits December 20, 2024 22:01

Merge branch 'main' into height-config

f274bad

Merge remote-tracking branch 'upstream/main' into height-config

84b0bc9

Update solarxr-protocol

bb02160

Fix height button logic & simplify validation

3afc977

Merge remote-tracking branch 'upstream/main' into height-config

4f4b2c6

ImUrX removed the Status: Blocked by other issue Progress cannot be made until linked issue is resolved label Jan 23, 2025

ImUrX added 2 commits January 23, 2025 16:45

Merge branch 'main' into height-config

7707017

Merge branch 'main' into height-config

acc38b9

ImUrX merged commit 4ad9d5c into main Jan 23, 2025
13 checks passed

ImUrX deleted the height-config branch January 23, 2025 16:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expand skeleton height config #1156

Expand skeleton height config #1156

ButterscotchV commented Sep 8, 2024 •

edited by ImUrX

Loading

loucass003 Nov 25, 2024

ImUrX Nov 29, 2024

loucass003 Nov 25, 2024

loucass003 Nov 25, 2024

ImUrX Nov 29, 2024

ButterscotchV commented Dec 19, 2024

ImUrX commented Dec 20, 2024

		@@ -35,7 +61,19 @@ export function NumberSelector({
		<div className="flex flex-col gap-1 w-full">

Expand skeleton height config #1156

Expand skeleton height config #1156

Conversation

ButterscotchV commented Sep 8, 2024 • edited by ImUrX Loading

loucass003 Nov 25, 2024

Choose a reason for hiding this comment

ImUrX Nov 29, 2024

Choose a reason for hiding this comment

loucass003 Nov 25, 2024

Choose a reason for hiding this comment

loucass003 Nov 25, 2024

Choose a reason for hiding this comment

ImUrX Nov 29, 2024

Choose a reason for hiding this comment

ButterscotchV commented Dec 19, 2024

ImUrX commented Dec 20, 2024

ButterscotchV commented Sep 8, 2024 •

edited by ImUrX

Loading