Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUD-1540 - feat: set sample rate to be min of global and metric sample rate #11

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

drwho725
Copy link

No description provided.

@magus424
Copy link

Is there a reason for doing min, rather than just always taking the one on the individual call?

i.e. what if you wanted a global default of 50% but for one specific metric you wanted 100%?

@drwho725
Copy link
Author

Is there a reason for doing min, rather than just always taking the one on the individual call?

i.e. what if you wanted a global default of 50% but for one specific metric you wanted 100%?

Talking with @bfeaver , if you want something that's 100% accurate (like counter) statsd isn't the solution

@drwho725 drwho725 merged commit 34a2ca7 into master Dec 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants