Merge pull request #10 from SkwalExe/eslint

improve eslint config

README.md

@@ -214,7 +214,7 @@ git checkout -b my-new-feature
 - When you finished your changes, you must check your code's formatting and linting and fix all the errors.
 
 ```bash
-npm run lint-fix
+npm run lint:fix
 npm run format
 ```
 

eslint.config.mjs

@@ -1,15 +1,16 @@
-import eslint from '@eslint/js'
-import tseslint from 'typescript-eslint'
+import ts from 'typescript-eslint'
+import eslintConfigPrettier from 'eslint-config-prettier'
 
-export default tseslint.config(
-    eslint.configs.recommended,
-    ...tseslint.configs.recommended,
+export default ts.config(
+    ...ts.configs.recommended,
+    eslintConfigPrettier,
+    // If ignores is used without any other keys in the configuration object, then the patterns act as global ignores.
+    // ref: https://eslint.org/docs/latest/use/configure/configuration-files#globally-ignoring-files-with-ignores
+    {
+        ignores: ['dist/**/*']
+    },
     {
-        files: ['**/*.ts', 'eslint.config.mjs'],
         rules: {
-            'indent': 'off', // conflicts with prettier
-            'eol-last': 'error',
-            'quotes': 'off', // conflicts
             'prefer-arrow-callback': 'error',
             'func-style': ['error', 'expression'],
             'no-trailing-spaces': 'error',
@@ -22,11 +23,10 @@ export default tseslint.config(
             'array-bracket-spacing': 'off',
             'array-element-newline': ['error', 'consistent'],
             'arrow-spacing': ['error', { before: true, after: true }],
-            'comma-dangle': 'off', // conflicts
             'comma-spacing': ['error', { before: false, after: true }],
             'linebreak-style': ['error', 'unix'],
             'spaced-comment': ['error', 'always'],
-            'no-unused-vars': 'off',
-        },
-    },
+            'no-unused-vars': 'off'
+        }
+    }
 )

package.json

@@ -24,12 +24,12 @@
         "@babel/core": "^7.24.5",
         "@babel/preset-env": "^7.24.5",
         "@babel/preset-typescript": "^7.24.1",
-        "@eslint/js": "^9.2.0",
         "@rollup/plugin-babel": "^6.0.4",
         "@rollup/plugin-node-resolve": "^15.2.3",
         "@rollup/plugin-typescript": "^11.1.6",
         "concurrently": "^8.2.2",
         "eslint": "^8.57.0",
+        "eslint-config-prettier": "^9.1.0",
         "prettier": "^3.2.5",
         "rollup": "^4.17.2",
         "rollup-plugin-livereload": "^2.0.5",
@@ -40,8 +40,8 @@
         "typescript-eslint": "^7.8.0"
     },
     "scripts": {
-        "lint": "eslint **/*.ts",
-        "lint-fix": "eslint --fix **/*.ts",
+        "lint": "eslint .",
+        "lint:fix": "eslint --fix .",
         "format": "prettier ./src/**/*.ts --config prettier.config.mjs --write",
         "clean": "shx rm -rf ./dist",
         "build:cjs": "tsc -m commonjs --target es2017 --outDir ./dist/lib-cjs/",

src/utils.ts

@@ -11,4 +11,7 @@ export const playSound = (path: string) => {
     audio.play()
 }
 
-export const random = (list: unknown[]) => list[Math.floor(Math.random() * list.length)]
+export const random = <T>(list: T[]): T => {
+    if (list.length === 0) throw new Error('random() got an empty array')
+    return list[Math.floor(Math.random() * list.length)]!
+}