Add coinbase_output_max_sigops

Sjors · Dec 16, 2024 · b1802e0 · b1802e0
1 parent 04d76c7
commit b1802e0
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/src/sv2/messages.h b/src/sv2/messages.h
@@ -149,17 +149,24 @@ struct Sv2CoinbaseOutputConstraintsMsg
      */
     uint32_t m_coinbase_output_max_additional_size;
 
+    /**
+     * The maximum additional sigops which the pool will add in coinbase transaction outputs.
+     */
+    uint16_t m_coinbase_output_max_sigops;
+
     template <typename Stream>
     void Serialize(Stream& s) const
     {
         s << m_coinbase_output_max_additional_size;
+        s << m_coinbase_output_max_sigops;
     };
 
 
     template <typename Stream>
     void Unserialize(Stream& s)
     {
         s >> m_coinbase_output_max_additional_size;
+        s >> m_coinbase_output_max_sigops;
     }
 };
 

diff --git a/src/test/sv2_template_provider_tests.cpp b/src/test/sv2_template_provider_tests.cpp
@@ -158,7 +158,8 @@ BOOST_AUTO_TEST_CASE(client_tests)
     BOOST_REQUIRE(tester.GetBlockTemplateCount() == 0);
 
     std::vector<uint8_t> coinbase_output_constraint_bytes{
-        0x01, 0x00, 0x00, 0x00
+        0x01, 0x00, 0x00, 0x00, // coinbase_output_max_additional_size
+        0x00, 0x00              // coinbase_output_max_sigops
     };
     node::Sv2NetMsg msg{node::Sv2MsgType::COINBASE_OUTPUT_CONSTRAINTS, std::move(coinbase_output_constraint_bytes)};
     tester.receiveMessage(msg);

diff --git a/src/test/sv2_transport_tests.cpp b/src/test/sv2_transport_tests.cpp
@@ -363,7 +363,7 @@ BOOST_AUTO_TEST_CASE(sv2_transport_responder_test)
         tester.CompareHash();
 
         // Handshake complete, have the initiator send us a message:
-        Sv2CoinbaseOutputConstraintsMsg body{4000};
+        Sv2CoinbaseOutputConstraintsMsg body{4000, 400};
         Sv2NetMsg msg{body};
         BOOST_REQUIRE(msg.m_msg_type == Sv2MsgType::COINBASE_OUTPUT_CONSTRAINTS);