Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fonts Reference and Introduce Shared TextOptions #177

Merged
merged 5 commits into from
Nov 22, 2021

Conversation

JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Nov 17, 2021

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes #174 , #17, #81

Also provides font hinting support which may allow us to close off #134 but will have to confirm the output to be certain.

  • Updates the reference to SixLabors.Fonts bringing with it the new text layout engine.
  • Introduces the shared TextOptions type from Fonts which replaces the RendererOptions/TextOptions types that handled text processing options.
  • Updates all DrawTextExtensions methods to use the new options type in addition to individual property driven overloads.

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #177 (7012259) into master (e987bd8) will decrease coverage by 0%.
The diff coverage is 82%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #177   +/-   ##
=====================================
- Coverage      69%    69%   -1%     
=====================================
  Files          89     87    -2     
  Lines        5204   5116   -88     
  Branches     1065   1062    -3     
=====================================
- Hits         3642   3554   -88     
- Misses       1347   1348    +1     
+ Partials      215    214    -1     
Flag Coverage Δ
unittests 69% <82%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/ImageSharp.Drawing/Processing/DrawingOptions.cs 86% <ø> (-4%) ⬇️
src/ImageSharp.Drawing/Shapes/Text/TextBuilder.cs 0% <0%> (ø)
...rawing/Processing/Extensions/DrawTextExtensions.cs 80% <84%> (-20%) ⬇️
...ing/Processing/DrawingOptionsDefaultsExtensions.cs 100% <100%> (ø)
...p.Drawing/Processing/Extensions/ClearExtensions.cs 100% <100%> (ø)
...ng/Processing/Processors/Text/DrawTextProcessor.cs 88% <100%> (-2%) ⬇️
...ssing/Processors/Text/DrawTextProcessor{TPixel}.cs 96% <100%> (+<1%) ⬆️
src/ImageSharp.Drawing/Processing/ShapeOptions.cs 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e987bd8...7012259. Read the comment docs.

This was linked to issues Nov 19, 2021
@JimBobSquarePants JimBobSquarePants merged commit b054d68 into master Nov 22, 2021
@JimBobSquarePants JimBobSquarePants deleted the js/text-options branch November 22, 2021 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with TextOptions and Fonts.RendererOptions Render text with ligatures Support for RTL text
1 participant