Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncTask 関連のテンプレートパラメータ制約を修正 #1213

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

Raclamusi
Copy link
Member

AsyncTask のコンストラクタテンプレートや推論補助、ヘルパ関数テンプレートのテンプレートパラメータ制約に std::decay_t がついておらず、オーバーロード解決に失敗することがあったので、修正しました。

失敗するコード

# include <Siv3D.hpp> // OpenSiv3D v0.6.14

struct Func
{
	int32 operator()(int32 x) const
	{
		return 0;
	}

	int64 operator()(int32& x) const
	{
		return 0;
	}
};

void Main()
{
	int32 x = 0;
	AsyncTask task(Func{}, x);
}

@Reputeless Reputeless merged commit c1beee0 into Siv3D:v6_develop Mar 16, 2024
2 checks passed
@Reputeless
Copy link
Member

Merged. Goog catch!
siv8 にも反映させておきます。

Reputeless added a commit to Siv3D/siv8 that referenced this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants