Account for configuration channels in NetworkRegistryMixin#preserveSendableChannels
#171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndableChannels Fixes client disconnecting from dedicated server with Fabric mods that register configuration phase packets Signed-off-by: unilock <[email protected]>
|
This PR doesn't help solve the issue |
|
@Tapacywka That's the issue this PR is supposed to fix, and it did appear to fix it for me... I'm not sure what the issue could still be. Hopefully someone who's more knowledgeable about payload registration can shed some insight. |
Su5eD
added
bug
|
This PR did help to solve ZsoltMolnarrr/SpellEngine#80 for me, just checked on local machine. |
Su5eD
approved these changes
Jan 29, 2025
|
Thanks for contributing the fix! |
TexBlock
added a commit
to ThinkingStudios/FoxifiedNetworking
that referenced
this pull request
Jan 30, 2025
- Account for configuration channels in NetworkRegistryMixin#preserveSendableChannels ([Sinytra/ForgifiedFabricAPI#171](Sinytra/ForgifiedFabricAPI#171))
TexBlock
added a commit
to ThinkingStudios/FoxifiedNetworking
that referenced
this pull request
Jan 30, 2025
- Account for configuration channels in NetworkRegistryMixin#preserveSendableChannels ([Sinytra/ForgifiedFabricAPI#171](Sinytra/ForgifiedFabricAPI#171))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes client disconnecting from dedicated server with Fabric mods that register configuration phase packets (such as Spell Engine)