-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add drop-in Playlist support #586
base: itgmania-beta
Are you sure you want to change the base?
Add drop-in Playlist support #586
Conversation
(Still in "Other" directory currently, but can/will move after discussing where it should go and other implementation stuffs) |
Yeah! So I think we have two options.
I think in both cases there should be some logic to determine what we do if all the songs aren't available on the machine. I would say we should either not display the playlist or display an empty one with a caution sign saying not all songs are found on the playlist. Another option would be display the songs that are found. I'm not sure out of these we should go with but open to hearing thoughts. |
I think most preferable is a message saying not all songs are found and listing the ones which aren't found. |
…n (rather than just the result of a function)
Hmm, putting into profiles i think is a good idea actually. My only thought is I think it could be useful for machine owners to be able to define a preset of songs that exist irregardless of the profile connected. That way it could be used for recs, curated song lists, or local competitions (this has been my main use so far). It's technically possible to have this behavior if its completely moved to profiles but then it requires every profile to have the same Playlist folder in it which i feel like could get redundant and makes it difficult to make changes. Maybe it's still profile dependent, but the "Machine" also has Playlists and those appear for everyone at the top of the list? Hm I think we should definitely show everything that is available, but maybe have a caution sign on the side of the section name to indicate that songs are missing from it. Though if that's applied here it should probably also be applied for favorites? Edit 1: Thinking about it more and how that would look in the sort menu, my opinion i think is maybe profiles still just have Favorites (since that supports multiple sections) and Playlists are just machine based and perhaps just moved somewhere more convenient/intuitive? Two people with a lot of playlists i feel like could be a lot to scroll through all in the wheel and determining who's playlist is whose i feel like could be a little messy? Could potentially conflict a bit w/ favorites since at that point you might as well just use playlists to achieve the same thing |
f864614
to
fba43f2
Compare
This PR is split from and dependent upon the implementation of the Sort Menu discussed here: #585.
Attaching the same video since it shows Playlists in use at the end.
SubSort2.mp4