Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kitsune #586

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Kitsune #586

wants to merge 11 commits into from

Conversation

AeraAuling
Copy link

@AeraAuling AeraAuling commented Jul 23, 2024

Description

This is a draft PR for kitsune, following a suggestion to make one. Kitsune are a new species of Fox-like humanoids.

Kitsune are intended to be a more mystical, psionically connected species with a connection to fire and the ability to shift between a humanoid and a fox form. As of right now, they share a lot of details with felinids due to them being used as an example of how to build a species. This will change however, as they are intended to be balanced around a smaller health value, their ability to shift forms, and their inherent connection to psionics and amping bonus

The todo list holds most of the details. As of right now kitsune are "playable" in that they have one of their abilities, deal heat damage on their unarmed attack, and can spawn a foxfire entity but there's still quite a bit to do. this will presumably be updated as things are added supposing I have how these work correct

In terms of credit, VMSolidus worked on the original YAML, though a good part of it has been redone at this point by myself. I've worked on or altered most of the sprite work, and the C# code wouldn't have been possible without Pspritechologist's knowledge and help


TODO

  • Create the humanoid kitsune
  • Make a kitsune language
  • Complete foxfire and make it spawnable (icon fixed)
  • create the foxform
  • make a way for the kitsune to transform into the foxform
  • fill out the humanoid forms unique stats and health values(likely 85/185 crit/death values)
  • add fox sounds and create kitsune sound collections
  • make the foxfire inherit the kitsune hair color
  • make the kitsune foxform inherit markings and customization colors
  • create new ear and tail markings
  • give kitsune an inherent amping bonus (to be done with future psionic refactors)
  • potentially give them a glimmer based projectile??
  • fix Urist Mckitsune so they are no longer just Big Felinid

Media

07e075d14baaa2bd750eb28abbe1eea2-1


Changelog

🆑

  • add: Added fox :D
  • tweak: Tweaked fox
  • fix: Fixed fox!
  • remove: Removed fox :(

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files labels Jul 23, 2024
Copy link
Contributor

github-actions bot commented Jul 23, 2024

RSI Diff Bot; head commit ddeddc7 merging into a1aaa35
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Mobs/Customization/kitsune/ears.rsi

State Old New Status
kitsune_fluffy_ears Added
kitsune_fluffy_fluff Added

Resources/Textures/Mobs/Customization/kitsune/foxform.rsi

State Old New Status
kitsune_fox_body Added
kitsune_fox_innerear Added

Resources/Textures/Mobs/Customization/kitsune/kitsune_masking_helpers.rsi

State Old New Status
mask Added

Resources/Textures/Mobs/Customization/kitsune/tails.rsi

State Old New Status
fluffy_tail_reshaded Added
kitsune_primary Added
kitsune_secondary Added

Resources/Textures/Structures/Specific/Species/Kitsune/foxfire.rsi

State Old New Status
foxfire Added
icon Added

Edit: diff updated after ddeddc7

@VMSolidus
Copy link
Member

Fari_heart

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Aug 21, 2024
@FoxxoTrystan
Copy link
Contributor

Is this PR still being worked on?

@AeraAuling
Copy link
Author

Is this PR still being worked on?

finishing it will require a refactor of the polymorph system. It can, theoretically, be done with the current one by commenting out the PDA drop code but i'm hesitant to just change enough to be "good enough" and having said refactor pushed back indefinitely

@VMSolidus
Copy link
Member

Is this PR still being worked on?

finishing it will require a refactor of the polymorph system. It can, theoretically, be done with the current one by commenting out the PDA drop code but i'm hesitant to just change enough to be "good enough" and having said refactor pushed back indefinitely

I can do that for you absolutely right now if you'd like.

@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Oct 1, 2024
@FoxxoTrystan
Copy link
Contributor

Is this PR still being worked on?

finishing it will require a refactor of the polymorph system. It can, theoretically, be done with the current one by commenting out the PDA drop code but i'm hesitant to just change enough to be "good enough" and having said refactor pushed back indefinitely

I can do that for you absolutely right now if you'd like.

NO YOU WORK ON LAMIA!

@AeraAuling
Copy link
Author

Is this PR still being worked on?

finishing it will require a refactor of the polymorph system. It can, theoretically, be done with the current one by commenting out the PDA drop code but i'm hesitant to just change enough to be "good enough" and having said refactor pushed back indefinitely

I can do that for you absolutely right now if you'd like.

up to you. for kitsune specifically it needs a polymorph method that'll transfer accesses and can be forced back to the original form on crit/stun, but given it'd be for polymorphing as a whole, there'd also need to be stuff for the other methods of polymorphing like artifact reactions and admin smites, and honestly I imagine you'd probably want to make it something that could be worked into powers as well for stuff like wizard

@VMSolidus
Copy link
Member

Is this PR still being worked on?

finishing it will require a refactor of the polymorph system. It can, theoretically, be done with the current one by commenting out the PDA drop code but i'm hesitant to just change enough to be "good enough" and having said refactor pushed back indefinitely

I can do that for you absolutely right now if you'd like.

up to you. for kitsune specifically it needs a polymorph method that'll transfer accesses and can be forced back to the original form on crit/stun, but given it'd be for polymorphing as a whole, there'd also need to be stuff for the other methods of polymorphing like artifact reactions and admin smites, and honestly I imagine you'd probably want to make it something that could be worked into powers as well for stuff like wizard

I found where the PDA bug lived, and it was specifically because PDAs were set to "quickEquip: false".
You're good to go. Actually let me also set them up with some cool new goodies.

@VMSolidus
Copy link
Member

VMSolidus commented Oct 1, 2024

Alright you now have Psionic System integrations for Kitsune. Foxfire is now treated by the game as a Psionic Power, and is beholden to all the same limitations of psionics. Kitsune now have everything we originally planned them to have as related to Psionics.

  • Starts with the Latent Psychic trait for free. They still however have to either roll for, or buy Natural Telepath to have access to Telepathy.

  • Baseline Amplification & Dampening is 0.15 higher for Kitsune. They are SLIGHTLY better at psionic casting than other people.

  • Gains 50% more Potentia when rolling for powers. Effectively, Kitsune are extremely talented at gaining magical abilities compared to normal people.

  • Foxfire works as a Psionic power, IE: Requires the caster be Psionic(If a Kitsune is Mindbroken they lose their innate ability), requires the caster not be Insulated, etc. Foxfire also doesn't occupy a spell slot, so it's a "Freebie" power for Kitsune.

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Status: Merge Conflict FIX YOUR PR AAAGH
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants