Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyter_lab: include base_url in proxy_url #286

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

quantumsteve
Copy link

This adds base_url to the jupyterlab proxy_url. By default, base_url = "/" which provides the same behavior. If base_url is different, then the proxy_url should change to reflect this.

to test:

One can recreate the same issue with just the julia-notebook container. Run it interactively to skip the startup script

docker run -p 8888:8888 -it quay.io/jupyter/julia-notebook:python-3.12 /bin/bash

start jupyter-lab and modify ServerApp.base_url

jupyter lab --no-browser --ServerApp.base_url="ipython"

open the link in your brower, run the commands in the image and get a websocker error
image

With this branch the websocket error disappears and pan/zoom works in the scatter plot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant