jupyter_lab: include base_url in proxy_url #286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds base_url to the jupyterlab proxy_url. By default, base_url = "/" which provides the same behavior. If base_url is different, then the proxy_url should change to reflect this.
to test:
One can recreate the same issue with just the julia-notebook container. Run it interactively to skip the startup script
start jupyter-lab and modify ServerApp.base_url
open the link in your brower, run the commands in the image and get a websocker error
With this branch the websocket error disappears and pan/zoom works in the scatter plot.