Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): Make build dependencies optional to unbreak install #7298

Merged

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Jul 1, 2024

Background

The cx-freeze dependency was changed to a git dependency in #7271. This requires python3-dev to be installed locally to build the cx-freeze package when you run poetry install.

Changes 🏗️

  • Create (optional) build dependency group
  • Move cx-freeze dependency to build dependency group

To include this group when installing dependencies, run poetry install with the --with=build option.

PR Quality Scorecard ✨

  • Have you used the PR description template?   +2 pts
  • Is your pull request atomic, focusing on a single change?   +5 pts
  • Have you linked the GitHub issue(s) that this PR addresses?   +5 pts
  • Have you documented your changes clearly and comprehensively?   +5 pts
  • Have you changed or added a feature?   -4 pts
    • Have you added/updated corresponding documentation?   +4 pts
    • Have you added/updated corresponding integration tests?   +5 pts
  • Have you changed the behavior of AutoGPT?   -5 pts
    • Have you also run agbenchmark to verify that these changes do not regress performance?   +10 pts

Fixes #7297 (`cx-freeze` dependency install fails after #7271)
@Pwuts Pwuts requested a review from a team as a code owner July 1, 2024 23:42
@Pwuts Pwuts requested review from kcze and majdyz and removed request for a team July 1, 2024 23:42
Copy link

netlify bot commented Jul 1, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 39cf2cf
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/66834278ef7ba9000988ae96

@Pwuts Pwuts requested a review from ntindle July 1, 2024 23:43
@Pwuts Pwuts added the setup Issues with getting Auto-GPT setup on local machines label Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.94%. Comparing base (cbae8b5) to head (39cf2cf).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7298      +/-   ##
==========================================
+ Coverage   27.89%   35.94%   +8.05%     
==========================================
  Files         102       18      -84     
  Lines        6554     1263    -5291     
  Branches      961      191     -770     
==========================================
- Hits         1828      454    -1374     
+ Misses       4642      779    -3863     
+ Partials       84       30      -54     
Flag Coverage Δ
Linux 35.94% <ø> (+8.05%) ⬆️
Windows 35.80% <ø> (+5.80%) ⬆️
agbenchmark ?
autogpt-agent 35.94% <ø> (ø)
forge ?
macOS 35.94% <ø> (+8.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pwuts
Copy link
Member Author

Pwuts commented Jul 1, 2024

Merging this without waiting on approval because it is an urgent fix

@Pwuts Pwuts merged commit 2fa4fd2 into master Jul 2, 2024
23 checks passed
@Pwuts Pwuts deleted the reinier/open-1353-cx-freeze-fails-to-install-since-7271 branch July 2, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Classic AutoGPT Agent setup Issues with getting Auto-GPT setup on local machines size/m
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

cx-freeze fails to install since #7271
1 participant