feat(forge, agent, benchmark): Upgrade to Pydantic v2 #7280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
github-actions
bot
added
the
conflicts
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
✅ Deploy Preview for auto-gpt-docs canceled.
|
github-actions
bot
removed
the
conflicts
|
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7280 +/- ##
==========================================
+ Coverage 25.50% 28.00% +2.49%
==========================================
Files 80 102 +22
Lines 4662 6557 +1895
Branches 631 961 +330
==========================================
+ Hits 1189 1836 +647
- Misses 3403 4640 +1237
- Partials 70 81 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kcze
changed the title
kcze
requested review from
Torantulino,
aarushik93 and
Pwuts
and removed request for
a team,
Torantulino and
aarushik93
kcze
commented
Jul 1, 2024
kcze
force-pushed
the
kpczerwinski/open-1346-update-pydantic-to-v2
branch
from
341bdf3 to
012cb15
Compare
kcze
commented
Jul 1, 2024
kcze
commented
Jul 1, 2024
Pwuts
requested changes
Jul 2, 2024
github-actions
bot
added
the
conflicts
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
github-actions
bot
removed
the
conflicts
|
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
Pwuts
requested changes
Jul 2, 2024
Pwuts
reviewed
Jul 2, 2024
| @@ -9,21 +9,23 @@ packages = [{ include = "agbenchmark" }] | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = "^3.10" | |||
| # helicone = "^1.0.9" # incompatible with openai@^1.0.0 | |||
| agent-protocol-client = "^1.1.0" | |||
| agent-protocol-client = {git = "https://github.com/Significant-Gravitas/agent-protocol.git", subdirectory = "packages/client/python"} | |||
There was a problem hiding this comment.
- fix(client/python): Update generator script and config for Pydantic v2 and re-generate agent-protocol#2
- Make
v1.2.0tag after merging above PR - Pin this dependency to
rev = "v1.2.0"to prevent it from auto-updating to dev versions
There was a problem hiding this comment.
This can wait until after this PR is merged
Pwuts
changed the title
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Agent Server is incompatible with AutoGPT&Forge because they use pydantic v2 and v1 respectively.
Changes 🏗️
Update Pydantic dependency of
autogpt,forgeandbenchmarkto^2.7Pydantic Migration Guide
Nonehas to be specified explicitly forOptionaland model fields without defaults are required (Ellipsis...for required fields is deprecated)Configclass for specifying model configuration is deprecated, nowmodel_configclass attribute needs to be set toConfigDictobject with configurationkwargs(extra) can no longer be passed toFieldagent-protocoland updated only client package: https://github.com/kcze/agent-protocolModelContainerinBaseAgent, component configuration is now serialized using Pydantic v2 functions directlyPR Quality Scorecard ✨
+2 pts+5 pts+5 pts+5 pts-4 pts+4 pts+5 pts-5 ptsagbenchmarkto verify that these changes do not regress performance?+10 pts