Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery via registry queries detection added #5165

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

xlazarg
Copy link

@xlazarg xlazarg commented Jan 19, 2025

Summary of the Pull Request

This PR adds a rule to detect instances of direct registry querying related to system information.

Changelog

new: System Information Discovery via Registry Queries

Example Log Event

399590877-cb8ad585-ab79-4323-b921-16f8e8ddfb06

Fixed Issues

SigmaHQ Rule Creation Conventions

  • If your PR adds new rules, please consider following and applying these conventions

@github-actions github-actions bot added Rules Windows Pull request add/update windows related rules labels Jan 19, 2025
@nasbench nasbench requested review from frack113 and nasbench January 22, 2025 21:42
Copy link
Member

@frack113 frack113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the rule is low , we can be less strict on the registry key.

@nasbench nasbench added the 2nd Review Needed PR need a second approval label Jan 31, 2025
@xlazarg
Copy link
Author

xlazarg commented Mar 7, 2025

Should I make any changes to the rule?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2nd Review Needed PR need a second approval Rules Windows Pull request add/update windows related rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants