Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v4 tables for samples and time series #24

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

srikanthccv
Copy link
Member

No description provided.

@srikanthccv srikanthccv marked this pull request as ready for review February 13, 2024 07:03
@srikanthccv
Copy link
Member Author

@ankitnayan PTAL

@ankitnayan
Copy link

Is the runTimeSeriesReloader loader needed anymore?

@ankitnayan
Copy link

Also, we cannot use cumulativetodeltaprocessor for all metrics ingested to our otel-collectors as promql queries won't work with delta right?

@srikanthccv
Copy link
Member Author

Is the runTimeSeriesReloader loader needed anymore?

It caused the OOM earlier. There should be some elaborative way to address that but it's a independent work.

@srikanthccv
Copy link
Member Author

Also, we cannot use cumulativetodeltaprocessor for all metrics ingested to our otel-collectors as promql queries won't work with delta right?

Yes, relying on PromQL is the last thing we want users to do. They are slower and more expensive. It's the worst of both of worlds (neither as good as Prometheus or ClickHouse) to try to remain fully PromQL compatible and ClickHouse. There are two metric types where temporality comes into the picture 1. Histogram 2. Counter and use cases are mostly known with these two, almost every query has some sort of (sum|avg|min|max)(rate|increase) all of which we support in the builder. If there is something we can't support, we will try to make it happen.

@srikanthccv srikanthccv merged commit 683712e into signoz/main Feb 14, 2024
24 of 49 checks passed
@srikanthccv srikanthccv deleted the use-v4-tables-for-promq branch February 14, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants