add weight sum < 1 invariant

Sifchain · Feb 17, 2022 · 7fa5b86 · 7fa5b86
1 parent 865472a
commit 7fa5b86
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/x/clp/types/params.go b/x/clp/types/params.go
@@ -81,12 +81,18 @@ func (p Params) Validate() error { // TODO determine all checks
 	if err := validatePmtpEndBlock(p.PmtpEndBlock); err != nil {
 		return err
 	}
-	if p.PmtpEndBlock < (p.PmtpStartBlock) {
+	if p.PmtpEndBlock < p.PmtpStartBlock {
 		return fmt.Errorf(
 			"end block (%d) must be after begin block (%d)",
 			p.PmtpEndBlock, p.PmtpStartBlock,
 		)
 	}
+	if p.PmtpNativeWeight.Add(p.PmtpExternalWeight).GT(sdk.NewDec(1)) {
+		return fmt.Errorf(
+			"sum of native weight (%d) and external weight (%d) cannot exceed 1",
+			p.PmtpEndBlock, p.PmtpStartBlock,
+		)
+	}
 	return nil
 }