Code

Ledger Review Fixes#3

Code

Merged

chris124567 merged 69 commits intomasterSiaFoundation/app-sia-x:masterfrom ledger-review-fixesSiaFoundation/app-sia-x:ledger-review-fixesCopy head branch name to clipboardFeb 12, 2024

+1,202-1,515

Commits

Commits on May 21, 2023

• add stax to sialedger and fix compiler warnings

  chris124567

  committed
  8c21657

  Copy full SHA for 8c21657

• add nanosp support

  chris124567

  committed
  4f6a1d0

  Copy full SHA for 4f6a1d0

• add address verification confirmation screen

  chris124567

  committed
  24e98ed

  Copy full SHA for 24e98ed

• add developer to about page

  chris124567

  committed
  0984b14

  Copy full SHA for 0984b14

• add nanosp icon and fix nanox load parameters

  chris124567

  committed
  be1de78

  Copy full SHA for be1de78

• fix icon in makefile

  chris124567

  committed
  916971e

  Copy full SHA for 916971e

Commits on May 30, 2023

• add status screens for all actions and fix address verification status

  chris124567

  committed
  7725dcf

  Copy full SHA for 7725dcf

Commits on Jun 3, 2023

• change transaction signing UI flow to Ledger recommendations

  chris124567

  committed
  cb311be

  Copy full SHA for cb311be

• fix tests

  chris124567

  committed
  27d0a9b

  Copy full SHA for 27d0a9b

Commits on Jun 7, 2023

• use nbgl_useCaseRegularReview instead of nbgl_useCaseForwardOnlyReview, where transaction hash confirmation page would get stuck if cancelled

  chris124567

  committed
  9d76068

  Copy full SHA for 9d76068

Commits on Nov 13, 2023

• store transaction elements data in fixed size array

  chris124567

  committed
  29d4480

  Copy full SHA for 29d4480

• remove displayIndex from struct to save memory, adjust MAX_ELEMS for nanos, redo test golden run (subtle differences in rendering)

  chris124567

  committed
  2c188b2

  Copy full SHA for 2c188b2

Commits on Nov 14, 2023

• get back button working on Stax

  chris124567

  committed
  0194144

  Copy full SHA for 0194144

• prefetch transaction on non stax devices

  chris124567

  committed
  e4e4562

  Copy full SHA for e4e4562

• disable txn test as it hangs for unknown reasons

  chris124567

  committed
  030e1b8

  Copy full SHA for 030e1b8

• fix bug where revisiting final page when calculating txn hash would cause hang

  chris124567

  committed
  62bb057

  Copy full SHA for 62bb057

Commits on Nov 15, 2023

• replace deprecated functions with new versions

  chris124567

  committed
  8bdb8a8

  Copy full SHA for 8bdb8a8

• fix bug where Nano version would crash if signing txns after another command due to uninitialized variable elementIndex in the context, make error handling consistent across devices

  chris124567

  committed
  ef29b28

  Copy full SHA for ef29b28

• fix Stax build warning

  chris124567

  committed
  ad75b1b

  Copy full SHA for ad75b1b

Commits on Nov 16, 2023

• only store encoded currencies and addresses to save space

  chris124567

  committed
  18d5125

  Copy full SHA for 18d5125

• fix cur2dec type cast build warning

  chris124567

  committed
  a5e69f1

  Copy full SHA for a5e69f1

Commits on Nov 17, 2023

• use uint8_t for elemType

  chris124567

  committed
  19fe48e

  Copy full SHA for 19fe48e

Commits on Nov 21, 2023

• save 7 bytes in transaction value field

  chris124567

  committed
  6d629ac

  Copy full SHA for 6d629ac

Commits on Nov 22, 2023

• fix werkzeug version

  chris124567

  committed
  fba1510

  Copy full SHA for fba1510

• update snapshots

  chris124567

  committed
  ccf7671

  Copy full SHA for ccf7671

Commits on Nov 27, 2023

• remove accidentally added formatSC call for Siafund values on Stax

  chris124567

  committed
  7764d44

  Copy full SHA for 7764d44

Commits on Nov 28, 2023

• Merge pull request #4 from SiaFoundation/make-back-button-work

  Show description for 791bbad
  lukechampine

  authored
  791bbad

  Copy full SHA for 791bbad

Commits on Dec 4, 2023

• remove UNUSED statement, use new boilerplate Makefile

  chris124567

  committed
  cc695db

  Copy full SHA for cc695db

• use nbgl_useCaseReviewStart on Stax for transactions

  chris124567

  committed
  b398e6b

  Copy full SHA for b398e6b

• replace main.c with app_main.c

  chris124567

  committed
  67ee12c

  Copy full SHA for 67ee12c

• update version number in tests

  chris124567

  committed
  6535d1d

  Copy full SHA for 6535d1d

• add ledger_app.toml

  chris124567

  committed
  c5d4933

  Copy full SHA for c5d4933

• fix variant

  chris124567

  committed
  c66a169

  Copy full SHA for c66a169

Commits on Dec 5, 2023

• makefile fixes

  chris124567

  committed
  e13c4d2

  Copy full SHA for e13c4d2

• change hashing UI

  chris124567

  committed
  d97fe0d

  Copy full SHA for d97fe0d

• remove unused variable

  chris124567

  committed
  03f4311

  Copy full SHA for 03f4311

Commits on Dec 10, 2023

• use new cryptography API

  chris124567

  committed
  7d8e8cd

  Copy full SHA for 7d8e8cd

• remove commented out code

  chris124567

  committed
  4180797

  Copy full SHA for 4180797

Commits on Dec 11, 2023

• remove private key option in deriveSiaKeypair

  chris124567

  committed
  d2771e6

  Copy full SHA for d2771e6

• add asserts for cryptographic function failure

  chris124567

  committed
  8b5082e

  Copy full SHA for 8b5082e

Commits on Dec 13, 2023

• assertion fixes and use raw buffer for public key

  chris124567

  committed
  ba7a42e

  Copy full SHA for ba7a42e

Commits on Dec 14, 2023

• reenable and clean up transaction tests

  chris124567

  committed
  b142ce7

  Copy full SHA for b142ce7

Commits on Dec 15, 2023

• use recommended labels for transaction elements and hold to sign

  chris124567

  committed
  c1bce62

  Copy full SHA for c1bce62

Commits on Dec 21, 2023

• remove unnecessary defines in makefile

  chris124567

  committed
  707cf19

  Copy full SHA for 707cf19

• remove unnecessary glyphs

  chris124567

  committed
  9307d77

  Copy full SHA for 9307d77

• use smaller types for blake2b

  chris124567

  committed
  e7cb773

  Copy full SHA for e7cb773

• don't use intermediate buffer if not necessary in blake2b_final

  chris124567

  committed
  9a6686f

  Copy full SHA for 9a6686f

• update README/Tutorial

  chris124567

  committed
  7123e99

  Copy full SHA for 7123e99

Commits on Dec 29, 2023

• follow signing guidelines

  chris124567

  committed
  ec73490

  Copy full SHA for ec73490

Commits on Jan 4, 2024

• remove not relevant checks

  chris124567

  committed
  13ce917

  Copy full SHA for 13ce917

• add .clang-format and format

  chris124567

  committed
  81e2d59

  Copy full SHA for 81e2d59

• format

  chris124567

  committed
  ac19d8c

  Copy full SHA for ac19d8c

• fix flags

  chris124567

  committed
  db0b16a

  Copy full SHA for db0b16a

• fix formatting again

  chris124567

  committed
  6ed3f98

  Copy full SHA for 6ed3f98

Commits on Jan 19, 2024

• remove unnecessary initialization code from main

  chris124567

  committed
  0b419aa

  Copy full SHA for 0b419aa

• remove unnecessary BAGL defines

  chris124567

  committed
  8c5b071

  Copy full SHA for 8c5b071

• format

  chris124567

  committed
  556616a

  Copy full SHA for 556616a

Commits on Jan 23, 2024

• change validate icon

  chris124567

  committed
  b1aeff3

  Copy full SHA for b1aeff3

• rename io_seproxyhal_cancel, remove io_seproxyhal_display(), io_event() and io_exchange_al()

  chris124567

  committed
  deccf19

  Copy full SHA for deccf19

• simplify handlers, rename cancel function, start switch to standard library io functions

  chris124567

  committed
  07905da

  Copy full SHA for 07905da

• use standard io library in all places

  chris124567

  committed
  2535e02

  Copy full SHA for 2535e02

Commits on Jan 25, 2024

• fixes for checks

  chris124567

  committed
  e1173ec

  Copy full SHA for e1173ec

Commits on Feb 5, 2024

• make sign hash compliant on stax

  chris124567

  committed
  77ccbb2

  Copy full SHA for 77ccbb2

• remove exceptions everywhere except txn.c (todo)

  chris124567

  committed
  518d041

  Copy full SHA for 518d041

• add stax test snapshots

  chris124567

  committed
  c0dd6ba

  Copy full SHA for c0dd6ba

Commits on Feb 7, 2024

• use more complicated test transaction

  chris124567

  committed
  1c0e738

  Copy full SHA for 1c0e738

• update snapshots

  chris124567

  committed
  6e2012b

  Copy full SHA for 6e2012b

Commits on Feb 9, 2024

• update comments

  chris124567

  committed
  a5a0b15

  Copy full SHA for a5a0b15

• remove unnecessary flag

  chris124567

  committed
  70229e2

  Copy full SHA for 70229e2