Submitting the merged files again #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s each (6 total). It is needed to find the error bar according to the three times of the same devices.
…clips_2_1st_repeat.gds
…clips_2_2nd_repeat.gds
…ips_2_1st_repeat.gds
…ips_1_1st_repeat.gds
…ips_1_2nd_repeat.gds
Each files of EBeam_Mehdi_paperclips_3 and EBeam_Mehdi_paperclips_4 has two more copies (..._2nd and ..._3rd). The input port names for the copied files are different to be able to differentiate the results. However, the measurements should be supposedly very similar. They only will be used to calculate the error bars.
4 More files to submit (in addition to the previous 6 files), 2 different files and only one copy of each one.
These two files are corrected. Errors: Disconnected ports.
Thanks for checking that. I actually forgot to delete the cell completely.
|
Thank you for your pull request! 👋 |
|
Thank you for your pull request! 👋 |
There are errors on RR5 and RR6. The reason is because I wanted two ring resonators (RR5 and RR6) include three and two rings in series, respectively. But closer than simply possible by connecting the defined ports. So, I was not sure how I could reduce the straight waveguide of each half-ring directional coupler to make the rings in series closer. This is the source of error. Is it still possible to fabricate them?
|
Thank you for your pull request! 👋 |
|
Thank you for your pull request! 👋 |
|
Thank you for your pull request! 👋 |
|
Thank you for your pull request! 👋 |
|
Thank you for your pull request! 👋 |
|
Thank you for your pull request! 👋 |
|
Thank you for your pull request! 👋 |
|
Thank you for your pull request! 👋 |
|
Thank you for your pull request! 👋 |
|
Thank you for your pull request! 👋 |
1 similar comment
|
Thank you for your pull request! 👋 |
|
Thank you for your pull request! 👋 |
|
Would you please sync your fork? I see some conflicts. |
|
Thank you for your pull request! 👋 |
|
I just synced the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting the merged files again but with two input laser ports on both of the GCs.