Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to upload design using python script with GDS Factory #172

Closed
wants to merge 9 commits into from

Conversation

lbelangers
Copy link
Contributor

As discussed in the Q&A, this is the design I'm having issues with (missing pins). I am unsure how the GitHub actions for running python files works, as it's not finding my python file.

Copy link

Thank you for your pull request! 👋

@lbelangers
Copy link
Contributor Author

It seems that the Python interpreter is missing dependencies.

Traceback (most recent call last):
  File "/home/runner/work/openEBL-2024-10/openEBL-2024-10/submissions/KLayout Python/EBeam_lbelangers2.py", line 1, in <module>
    import gdsfactory as gf
ModuleNotFoundError: No module named 'gdsfactory'

@lbelangers lbelangers closed this Oct 14, 2024
@lukasc-ubc
Copy link
Member

Hello @lbelangers

The design you submitted has problems with the grating couplers. You used a cell ("gc_te1550") that doesn't exist in the EBeam library. We replace all the grating couplers. And unfortunately your GC is also rotated relative to the ones in the library, so even if I replace it, I get an incorrect circuit.

image

Could you please fix your layout to use the "GC_TE_1550_8degOxide_BB" cell? This is the one that we replace it with.

Otherwise, we can fabricate your design using the GC layout you provided, but it looks like it is a design for -31 degrees, whereas we only test the chip with +8º couplers.

@lukasc-ubc lukasc-ubc reopened this Oct 14, 2024
Copy link

Thank you for your pull request! 👋

Copy link

Thank you for your pull request! 👋

Copy link

Thank you for your pull request! 👋

1 similar comment
Copy link

Thank you for your pull request! 👋

@lukasc-ubc
Copy link
Member

@lbelangers your gdsfactory code isn't compiling for some reason: https://github.com/SiEPIC/openEBL-2024-10/actions/runs/11321672596/job/31481081599?pr=172

@lbelangers
Copy link
Contributor Author

lbelangers commented Oct 14, 2024

Hello @lbelangers

The design you submitted has problems with the grating couplers. You used a cell ("gc_te1550") that doesn't exist in the EBeam library. We replace all the grating couplers. And unfortunately your GC is also rotated relative to the ones in the library, so even if I replace it, I get an incorrect circuit.

image Could you please fix your layout to use the "GC_TE_1550_8degOxide_BB" cell? This is the one that we replace it with.

Otherwise, we can fabricate your design using the GC layout you provided, but it looks like it is a design for -31 degrees, whereas we only test the chip with +8º couplers.

Hi,

I can't seem to find GC_TE_1550_8degOxide_BB in the ubcpdk package. Do I need to manually import the .gds to add it to my design.
About the code not compiling, the error seem to be raised inside the gds factory import. I tried locally to run the code with the specific python and gds factory versions, but am not able to reproduce.

@lukasc-ubc
Copy link
Member

Indeed, gdsfactory's PDK is out of date, and the GC cells need to be updated / imported from the main PDK.

@lukasc-ubc
Copy link
Member

We are now past the deadline.

Our next submission will be in February 2025.
The repository will be set up soon: https://github.com/SiEPIC/openEBL-2025-02

You may fix your design and submit next time.

thank you
Lukas

@lukasc-ubc lukasc-ubc closed this Oct 15, 2024
@lbelangers
Copy link
Contributor Author

If I understand correctly, my submission will still be fabricated as is (it's currently on the latest artifact), but will have greater insertion loss because the coupling angle is not the same?

@lukasc-ubc
Copy link
Member

lukasc-ubc commented Oct 15, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants