This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

Remove the `data/shopify_liquid/(tags|filters|objects).yml` files #674

Merged

Poitrin merged 1 commit into main from fix-656

Dec 15, 2022

Contributor

Poitrin commented Dec 5, 2022 •

edited

Loading

WHY are these changes introduced?

Fixes #656

WHAT is this pull request doing?

Removes the usage of data/shopify_liquid/tags.yml, data/shopify_liquid/filters.yml, data/shopify_liquid/objects.yml in favor of the SourceIndex, which holds the most updated values for objects, filters, and tags.
Transforms remaining .yml files to .json files, so that we only have 1 format.
Adds some logic for existing objects, filters, tags, so that it resembles the existing .yml files content.

How to test your changes?

Verify that code completion for tags is still working as before,
- and that the tags mentioned in LABELS_NOT_IN_SOURCE_INDEX are now suggested too.
Verify that code completion for objects is still working as before,
- and that customer_address and product_variant are suggested now, but offer no further suggestions like attribute suggestions.
Verify that code completion for filters is still working as before,
- and that the filters mentioned in LABELS_NOT_IN_SOURCE_INDEX are now suggested too.

Poitrin commented

View reviewed changes

lib/theme_check/shopify_liquid/source_index.rb Outdated Show resolved Hide resolved

Poitrin commented

View reviewed changes

test/shopify_liquid_test.rb Show resolved Hide resolved

Poitrin commented

View reviewed changes

data/shopify_liquid/plus_labels.json Show resolved Hide resolved

Poitrin commented

View reviewed changes

lib/theme_check/shopify_liquid/object.rb Show resolved Hide resolved

Poitrin commented

View reviewed changes

test/shopify_liquid_test.rb Show resolved Hide resolved

Poitrin force-pushed the fix-656 branch from d1e712d to a74bb88 Compare

December 6, 2022 09:07

Poitrin commented

View reviewed changes

lib/theme_check/shopify_liquid/tag.rb Show resolved Hide resolved

Poitrin commented

View reviewed changes

data/shopify_liquid/deprecated_filters.json Show resolved Hide resolved

Poitrin commented

View reviewed changes

lib/theme_check/shopify_liquid/deprecated_filter.rb Show resolved Hide resolved

Poitrin marked this pull request as ready for review

December 6, 2022 09:54

Poitrin requested review from karreiro and charlespwd

December 6, 2022 09:55

Poitrin linked an issue

that may be closed by this pull request

[Intelligent code completion] Remove the data/shopify_liquid/(tags|filters|objects).yml files #656

Closed

Base automatically changed from fix-658 to language-server-docs-main

December 9, 2022 15:38

Poitrin mentioned this pull request

[Intelligent code completion] Do not log an error when preceding assigned value is not mentioned in the docs #682

Closed

Poitrin changed the base branch from language-server-docs-main to main

December 15, 2022 08:21

Poitrin changed the base branch from main to language-server-docs-main

December 15, 2022 08:23

Poitrin changed the base branch from language-server-docs-main to main

December 15, 2022 08:25

karreiro reviewed

View reviewed changes

Contributor

karreiro left a comment

Thank you, @Poitrin! Excellent stuff 🚀

I've left just some minor comments. Please, let me know what you think about them :)

Poitrin force-pushed the fix-656 branch 3 times, most recently from 2c76768 to 895a507 Compare

December 15, 2022 12:51


          Remove the data/shopify_liquid/(tags|filters|objects).yml files

13dbadc

Poitrin force-pushed the fix-656 branch from 895a507 to 13dbadc Compare

December 15, 2022 13:19

Poitrin requested a review from karreiro

December 15, 2022 13:21

karreiro approved these changes

View reviewed changes

Contributor

karreiro left a comment

Thank you, @Poitrin 🔥🚀

Poitrin merged commit 0cf59c8 into main

Poitrin deleted the fix-656 branch

December 15, 2022 13:46

Poitrin restored the fix-656 branch

December 15, 2022 13:51

Poitrin mentioned this pull request

Only suggest filters available in SourceIndex #689

Merged

Poitrin pushed a commit that referenced this pull request


          Only suggest filters in SourceIndex (#689)

fcf9bca

### WHY are these changes introduced?

Relates to #656 and #674, rolls back changes to filters suggestion.

### WHAT is this pull request doing?

- Filters that were previously in `data/shopify_liquid/filters.yml` will not be suggested.
- Theme Check will accept these filters though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet