Add PR label action #1796
Merged
Add PR label action #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
force-pushed
the
uk-pr-labeller
branch
4 times, most recently
from
f548551 to
a1dd559
Compare
paracycle
force-pushed
the
uk-pr-labeller
branch
4 times, most recently
from
9ebdd95 to
cd2ccb2
Compare
paracycle
force-pushed
the
uk-pr-labeller
branch
from
cd2ccb2 to
a00ef41
Compare
paracycle
force-pushed
the
uk-pr-labeller
branch
2 times, most recently
from
dfe1e63 to
d0262f0
Compare
paracycle
added
chore
and removed
duplicate
paracycle
force-pushed
the
uk-pr-labeller
branch
2 times, most recently
from
0d88543 to
792f65f
Compare
paracycle
force-pushed
the
uk-pr-labeller
branch
from
792f65f to
2965750
Compare
vinistock
approved these changes
Feb 13, 2024
| - uses: actions/checkout@v4 | ||
| - name: Check for Pull Request Labels | ||
| run: | | ||
| REQUIRED_LABELS=("documentation" "bugfix" "chore" "enhancement" "ignore-for-release" "security" "sorbet") |
There was a problem hiding this comment.
Since the labels will now be required, I wonder if we're missing another category. For example, would a refactor fit into chore?
There was a problem hiding this comment.
We'd been using chore for refactors and most other non-user visible changes, yeah. Open to better suggestions, though.
There was a problem hiding this comment.
Okay. Honestly, that sounds good, I was just wondering. IMO, ship it and we'll identify if any categories are missing as we open PRs.
egiurleo
approved these changes
Feb 13, 2024
paracycle
force-pushed
the
uk-pr-labeller
branch
from
2965750 to
221764f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #1434
Implementation
We couldn't use a reusable action in #1435, but I realized that we can put together a quick action based on a bash script and some
ghwizardry.Tests
No tests