Skip to content

Commit

Permalink
Pull in newer gem versions that depend on base64
Browse files Browse the repository at this point in the history
  • Loading branch information
KaanOzkan committed Jan 6, 2025
1 parent 4182fc6 commit 92adc01
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
12 changes: 6 additions & 6 deletions spec/tapioca/cli/gem_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -747,7 +747,7 @@ class Secret; end

it "must generate git gem RBIs with source revision numbers" do
@project.write_gemfile!(<<~GEMFILE, append: true)
gem("faraday", git: "https://github.com/lostisland/faraday", ref: "23e249563613971ced8f851230c46b9eeeefe931")
gem("faraday", git: "https://github.com/lostisland/faraday", ref: "a9cf00425e3abc99b78952af44deb2912a65a882")
GEMFILE

@project.bundle_install!
Expand All @@ -757,7 +757,7 @@ class Secret; end
assert_stdout_includes(result, "Compiled faraday")

assert_project_file_exist(
"sorbet/rbi/gems/faraday@2.0.0.alpha.pre.4-23e249563613971ced8f851230c46b9eeeefe931.rbi",
"sorbet/rbi/gems/faraday@2.12.2-a9cf00425e3abc99b78952af44deb2912a65a882.rbi",
)

assert_empty_stderr(result)
Expand Down Expand Up @@ -1327,7 +1327,7 @@ class User; end
end

it "generates correct RBIs for a Rails engine in Zeitwerk mode" do
@project.require_real_gem("rails", "6.1.7.2")
@project.require_real_gem("rails", "7.1.5")
@project.require_real_gem("turbo-rails", "1.3.2")
@project.bundle_install!

Expand All @@ -1337,7 +1337,7 @@ class User; end
module Foo
class Application < Rails::Application
# Initialize configuration defaults for originally generated Rails version.
config.load_defaults 6.1
config.load_defaults 7.1
config.autoloader = :zeitwerk
end
end
Expand All @@ -1358,7 +1358,7 @@ class Application < Rails::Application
end

it "generates correct RBIs for a Rails engine in Classic mode" do
@project.require_real_gem("rails", "6.1.7.2")
@project.require_real_gem("rails", "7.1.5")
@project.require_real_gem("turbo-rails", "1.3.2")
@project.bundle_install!

Expand All @@ -1368,7 +1368,7 @@ class Application < Rails::Application
module Foo
class Application < Rails::Application
# Initialize configuration defaults for originally generated Rails version.
config.load_defaults 6.1
config.load_defaults 7.1
config.autoloader = :classic
end
end
Expand Down
2 changes: 1 addition & 1 deletion spec/tapioca/dsl/compilers/protobuf_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ def fields=(value); end
# This is test is based on this definition from `google-cloud-bigtable` gem that was causing issues:
# https://github.com/googleapis/google-cloud-ruby/blob/9de1ce5bf74105383fc46060600d5293f8692035/google-cloud-bigtable-admin-v2/lib/google/bigtable/admin/v2/bigtable_instance_admin_pb.rb#L20
add_ruby_file("protobuf.rb", <<~RUBY)
# require "base64"
require "base64"
require 'google/protobuf'
# This is how the new protobuf compiler (protoc) generates `xx_pb.rb` files.
Expand Down

0 comments on commit 92adc01

Please sign in to comment.