[Chore] Rearrange remix dependencies #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzaloriestra
approved these changes
Apr 24, 2024
paulomarg
force-pushed
the
remove_remix_run_node_dep
branch
from
d23a5d5 to
1b5d80e
Compare
paulomarg
changed the title
lizkenyon
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We accidentally made
@remix-run/nodea direct dependency of the remix package when we introduced the Vercel adapter. While every Vercel app already needs to have the node package, every non-node app won't need that package.WHAT is this pull request doing?
Making the node dependency a dev + peer combo, which means it's installed locally for development and expected to be installed in the app (which it already is in the template, and will have to be to run on Vercel anyway).
Type of change
Checklist
yarn changesetto create a draft changelog entry (do NOT update theCHANGELOG.mdfiles manually)