Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Closes #756
When all ids evaluated to falsey values in the REST resources'
find()
methods, we could end up defaulting to the non-id specific versions of a request - e.g./products/<id>.json
became/products.json
because we treated these ids as optional.However, typically in REST APIs, whenever we are GET-ing a specific item you'll need to supply its id, so it didn't make sense for
find()
to do an id-less query.WHAT is this pull request doing?
Making it possible to trigger an error if we're missing an id by passing in a parameter to
baseFind
, and updating allfind()
methods to pass that parameter in.I'm considering this a bug fix because those requests were never supposed to be fired in the first place and would cause unpredictable behaviour.
To review the "manual" changes, use this link.
Type of change
Checklist
yarn changeset
to create a draft changelog entry (do NOT update theCHANGELOG.md
files manually)