Unify rollup configs #800
Merged
Unify rollup configs #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
unify_rollup_configs
branch
from
ff3de01 to
2208ebe
Compare
lizkenyon
approved these changes
Apr 18, 2024
|
This technically only affects the old shopify-api-js repo packages 😅 - would you like to retest or shall I merge? |
|
@paulomarg tested with shopify-api! |
paulomarg
force-pushed
the
unify_rollup_configs
branch
from
2208ebe to
163f571
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
As part of joining the repos, we also started using rollup across the board. However, to make the changes smaller, I chose not to change the existing build pipelines for the previous shopify-api-js repo packages, which meant we had a bit of duplication.
WHAT is this pull request doing?
Using the same
rollup-utilsfunctions to build all of the packages.