Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Shop context to logs #1850

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add Shop context to logs #1850

wants to merge 4 commits into from

Conversation

lizkenyon
Copy link
Contributor

@lizkenyon lizkenyon commented Dec 9, 2024 •
edited
Loading

Reverts #1845

  • Adding back the logging the Shop context.
  • The previous PR had a bug due to an inconsistencies in the Checkout UI and Admin session token
  • Updated the Checkout UI authentication tests with session tokens that match reality.

@lizkenyon lizkenyon requested a review from a team as a code owner December 9, 2024 21:45
@lizkenyon lizkenyon force-pushed the revert-1845-revert-1779-liz/add-shop-to-logging branch from 22acc19 to 6106ceb Compare December 9, 2024 22:09
@lizkenyon lizkenyon force-pushed the revert-1845-revert-1779-liz/add-shop-to-logging branch from a852c95 to 34fc75d Compare December 9, 2024 22:19
@lizkenyon lizkenyon changed the title [WIP] Add Shop context to logs Add Shop context to logs Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteodepalo matteodepalo matteodepalo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lizkenyon @matteodepalo