feat: complete image filter api #2824
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdecampredon
force-pushed
the
feat-complete-image-filter
branch
from
f78a188 to
00fe164
Compare
wcandillon
reviewed
Dec 30, 2024
| */ | ||
| MakeBlend: ( |
There was a problem hiding this comment.
is there a way to clean up the diff here?
wcandillon
reviewed
Dec 30, 2024
| * @param dy - Offset along the X axis | ||
| * @param input - if null, it will use the dynamic source image | ||
| */ | ||
| MakeOffset( |
There was a problem hiding this comment.
Would it be possible to clean the diff on the this file?
wcandillon
reviewed
Dec 30, 2024
| throw new NotImplementedOnRNWeb(); | ||
| } | ||
|
|
||
| MakeDisplacementMap( |
There was a problem hiding this comment.
I think the diff is a bit dirty here.
wcandillon
reviewed
Dec 30, 2024
| return new JsiSkImageFilter( | ||
| this.CanvasKit, | ||
| this.CanvasKit.ImageFilter.MakeColorFilter( | ||
| JsiSkColorFilter.fromValue(cf), | ||
| input === null ? null : JsiSkImageFilter.fromValue(input) | ||
| input == null ? null : JsiSkImageFilter.fromValue(input) |
wcandillon
requested changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expose the complete set of ImageFilter available in Skia to the JS API