-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move test app to react-native-test-app #2746
base: main
Are you sure you want to change the base?
Conversation
@wcandillon Could I get the workflows approved so I can start testing my changes? |
@Saadnajmi I'm very excited about this and I will try to help as much as I can with it, however |
Makes sense! I should have left the PR in a draft state, my apologies. I figured I'd need to add back 95% of what was dropped as I ran into their use cases :) |
f9561a4
to
0579737
Compare
Hi, I'll be trying to pick this up again over the next couple of weeks, with the aim to add macOS support. Fingers crossed 🤞. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Saadnajmi thank you for doing this and I am ready to merge this asap. Reanimated doesn't configure on the Android build however.
'transform-inline-environment-variables', | ||
'react-native-reanimated/plugin', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is unfortunately needed for the E2E testing but I can gladly look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. Speaking of, could you approve the CI workflow so I can test this PR better?
I'll take a look at Android, thanks for noticing! For this PR, you don't have an issue with moving the examples to a more brownfield approach with react-native-test-app, where the list is in the app.json and each example is presented separately? I can keep the original App.tsx with rn-screens intact so migrating "back" is easy. |
TODO:
Summary
I am interested in (eventually) adding macOS support to react-native-skia. Generally the first step to this is to first move the repository's test app to React Native Test App. This repo offers a few benefits:
Notes
transform-inline-environment-variables
because things seemed to bundle fine without it?Test Plan
I got the iOS example app to run with the old architecture so far: