Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move over Sorbet stdlib types for the cmath gem #298

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Tom-Bonnike
Copy link

@Tom-Bonnike Tom-Bonnike commented Dec 20, 2024

Sorbet is soon going to stop shipping with types for a few core gems that aren’t bundled with ruby anymore since v2.7.0, see sorbet/sorbet#8377.
cmath is one of these gems, and there was some type annotations for it in the Sorbet repo. I’m just moving them over here instead. There seems to have been no update to the cmath gem since it was made a non-default gem in Ruby 2.7.0, but I still manually checked and the types look correct.

Type of Change

  • Add RBI for a new gem
  • Modify RBI for an existing gem
  • Other:

Changes

@Tom-Bonnike
Copy link
Author

I have signed the CLA!

@Tom-Bonnike Tom-Bonnike marked this pull request as ready for review December 23, 2024 09:40
@Tom-Bonnike Tom-Bonnike requested a review from a team as a code owner December 23, 2024 09:40
# typed: true

module CMath
include ::Math
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing CI for now but the duplication should be fine as users upgrade their Sorbet version. I'd like to keep the CI green though. Is it okay if this PR waits until Sorbet removal is merged and we bump the Sorbet version used in tests?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that makes sense — although we should aim for as little time as possible between the two merges, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants