Move over Sorbet stdlib types for the cmath
gem
#298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorbet is soon going to stop shipping with types for a few core gems that aren’t bundled with ruby anymore since v2.7.0, see sorbet/sorbet#8377.
cmath
is one of these gems, and there was some type annotations for it in the Sorbet repo. I’m just moving them over here instead. There seems to have been no update to thecmath
gem since it was made a non-default gem in Ruby 2.7.0, but I still manually checked and the types look correct.Type of Change
Changes
cmath