Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update sidekiq annotation #126

Merged
merged 2 commits into from
Nov 8, 2022
Merged

update sidekiq annotation #126

merged 2 commits into from
Nov 8, 2022

Conversation

leifg
Copy link
Contributor

@leifg leifg commented Nov 4, 2022 •
edited
Loading

Type of Change

As discussed in #124 sidekiq 7.0 has issue with referencing Sidekiq::Worker in srb.

  • Add RBI for a new gem
  • Modify RBI for an existing gem
  • Other:

Changes

  • Gem name: sidekiq
  • Gem version: 7.0.1
  • Gem source: rubygems
  • Tapioca version: 0.10.2
  • Sorbet version: 0.5.10517

@leifg leifg requested a review from a team as a code owner November 4, 2022 21:10
KaanOzkan
KaanOzkan reviewed Nov 4, 2022
View reviewed changes
Copy link
Contributor

@KaanOzkan KaanOzkan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is probably failing due to an outdated index.json file.

@leifg
Copy link
Contributor Author

leifg commented Nov 7, 2022

Is there anything to do on my side (I signed the CLA)

@Morriar
Copy link
Contributor

Morriar commented Nov 8, 2022

Is there anything to do on my side

Yes, I think you need to remove these imports from the index: https://github.com/Shopify/rbi-central/blob/main/index.json#L93-L95 since I don't see them in Sidekiq v7.0.

@KaanOzkan KaanOzkan merged commit c752b61 into Shopify:main Nov 8, 2022
@Morriar Morriar added the rbi Change related to RBI annotations label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaanOzkan KaanOzkan KaanOzkan approved these changes

Assignees
No one assigned
Labels
rbi Change related to RBI annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leifg @Morriar @KaanOzkan