Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change recommended drawing library #385

Closed
wants to merge 1 commit into from

Conversation

euglena1215
Copy link

What are you trying to accomplish?

Change the drawing library introduced as the packwerk ecosystem from graphwerk gem to visualize_packs gem.

What approach did you choose and why?

The graphwerk gem is introduced as part of the ecosystem, but the graphwerk gem has not been maintained recently.

Since the visualize_packs gem is more actively maintained, I thought it would be appropriate to introduce the visualize_packs gem as part of the ecosystem.

What should reviewers focus on?

Please determine if the visualize_packs gem is appropriate as a recommended drawing library.

Type of Change

  • Bugfix
  • New feature
  • Non-breaking change (a change that doesn't alter functionality - i.e., code refactor, configs, etc.)

Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • It is safe to rollback this change.

The graphwerk gem is introduced as part of the ecosystem,
but the graphwerk gem has not been maintained recently.

Since the visualize_packs gem is more actively maintained,
I thought it would be appropriate to introduce the visualize_packs gem as part of the ecosystem.
@euglena1215 euglena1215 requested a review from a team as a code owner January 16, 2024 15:39
@euglena1215
Copy link
Author

I have signed the CLA!

Copy link
Member

@gmcgibbon gmcgibbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, but this cannot be accepted. It is unfortunate that graphwerk hasn't been maintained recently, but I don't want to imply that one needs to use "packs" for visualization. It adds many features on top of Packwerk, some of which the maintainers of Packwerk disagree with.

@euglena1215
Copy link
Author

@gmcgibbon
Thanks for the review. I did not know that the visualize_packs gem depends on the directory name "packs".
So I can understand why it is not accepetable.

@euglena1215 euglena1215 deleted the change-draw-library branch January 21, 2024 01:22
@alexevanczuk
Copy link
Contributor

Hey @euglena1215 just wanted to chime in to say that packs-rails and the packs spec in general defaults to ./packs as the root dir, but the pack directories are totally configurable. Only saying that to clear up any misconceptions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants