Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump function-runner to v7.0.1 #5223

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Bump function-runner to v7.0.1 #5223

merged 1 commit into from
Jan 21, 2025

Conversation

adampetro
Copy link
Contributor

WHY are these changes introduced?

Bump to latest version of function-runner

WHAT is this pull request doing?

Bump the version that is downloaded

How to test your changes?

  • rm -r packages/app/dist/cli/services/bin/ (clear out any cached downloaded binaries)
  • pnpm shopify app function build --path <path_to_function_extension> (downloads and runs Javy)
  • cat <path_to_function_input> | pnpm shopify app function run --path <path_to_function_extension> (downloads and runs function-runner)

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes - not applicable

@adampetro adampetro requested review from a team as code owners January 16, 2025 22:59
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.25% (+0.02% 🔼)
8873/11792
🟡 Branches
70.45% (+0.03% 🔼)
4327/6142
🟡 Functions 75.03% 2323/3096
🟡 Lines
75.8% (+0.02% 🔼)
8388/11066

Test suite run success

2000 tests passing in 904 suites.

Report generated by 🧪jest coverage report action from f16483e

Copy link
Contributor

Question, if the binary is already there, it won't download the new version right?
Do we have a mechanism to force updates?

@adampetro
Copy link
Contributor Author

Question, if the binary is already there, it won't download the new version right?

Correct

Do we have a mechanism to force updates?

Yes, the user bumping the version of the CLI NPM package. The binary is downloaded to a path within the package, so when the package is bumped to a newer version, it's a new directory so the binary shouldn't be there.

@adampetro adampetro added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit da30052 Jan 21, 2025
27 checks passed
@adampetro adampetro deleted the ap.function-runner-v7.0.1 branch January 21, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants