-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - when accessing specific property, only deserialize that one #32
Open
mpollmeier
wants to merge
13
commits into
master
Choose a base branch
from
michael/deserializer-optimisations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml86
approved these changes
Jul 3, 2019
* before this change, the entire element would be deserialized * because the majority of properties are actually unused, this should save us a lot of time * best used in combination with cpg2overflowdb, i.e. we don't first initialize the entire graph, but only the element refs * change for binary format: instead of writing string property keys we index the properties, using `Nil` values to fill gaps * since we can hard code the property index and type in the specific classes, there's no need to have this in the binary format * internally I'm intending to use only the 'readSpecificProperty' rather than reading all properties - that'll come back as a traversal optimization later though.
SerializerTest is green
21e13f3
to
7a42bba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nil
values to fill gaps