Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new text-followup handler to use the output of text-followup preprocessor #948

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

VenissaCarolQuadros
Copy link
Member

@VenissaCarolQuadros VenissaCarolQuadros commented Jan 22, 2025

This handler responds to followup user queries using the output of the text-followup preprocessor (#947).

This handler has been tested for different queries using the command

jq '.followup.query = "<MY_QUERY>"' /home/venicq/follow-up.json | /var/docker/image/bin/sendimagereq /dev/stdin https://unicorn.cim.mcgill.ca/image/render/

Here are some examples:

  1. Response to generic query
Query: What are the people wearing?
Response: The women appear to be dressed in business casual attire, likely for an office setting.
  1. Logs and response when text-followup preprocessor is down/ returns invalid JSON (simulated by modifying prompt)
Logs: DEBUG:root:Text-followup preprocessor not found
Response: "renderings":[]

Required Information

  • I referenced the issue addressed in this PR.
  • I described the changes made and how these address the issue.
  • I described how I tested these changes.

Coding/Commit Requirements

  • I followed applicable coding standards where appropriate (e.g., PEP8)
  • I have not committed any models or other large files.

New Component Checklist (mandatory for new microservices)

  • I added an entry to docker-compose.yml and build.yml.
  • I created A CI workflow under .github/workflows.
  • I have created a README.md file that describes what the component does and what it depends on (other microservices, ML models, etc.).

OR

  • I have not added a new component in this PR.

@VenissaCarolQuadros VenissaCarolQuadros marked this pull request as ready for review January 23, 2025 02:54
@VenissaCarolQuadros VenissaCarolQuadros requested review from JRegimbal and removed request for JRegimbal January 23, 2025 02:55
@VenissaCarolQuadros VenissaCarolQuadros self-assigned this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants