Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S61: Reorganizing files to optimize docker caching layers #920

Merged
merged 6 commits into from
Dec 16, 2024
Merged

Conversation

shahdyousefak
Copy link
Contributor

@shahdyousefak shahdyousefak commented Nov 27, 2024

Please ensure you've followed the checklist and provide all the required information before requesting a review.
If you do not have everything applicable to your PR, it will not be reviewed!
If you don't know what something is or if it applies to you, ask!

Don't delete below this line.


Required Information

  • I referenced the issue addressed in this PR.
  • I described the changes made and how these address the issue. --> reorganized the structure of the Dockerfiles by moving the frequently changing files towards the end of the Dockerfiles while placing the least frequently changing files at the beginning.; aligns with Docker's layer-based caching mechanism to enhance build efficiency and minimize unnecessary rebuilds of unchanged components.
  • I described how I tested these changes. --> built the Docker images with the reorganized Dockerfiles; had little improvement to the time taken.

Coding/Commit Requirements

  • I followed applicable coding standards where appropriate (e.g., PEP8)
  • I have not committed any models or other large files.

New Component Checklist (mandatory for new microservices)

  • I added an entry to docker-compose.yml and build.yml.
  • I created A CI workflow under .github/workflows.
  • I have created a README.md file that describes what the component does and what it depends on (other microservices, ML models, etc.).

OR

  • I have not added a new component in this PR.

@shahdyousefak shahdyousefak changed the title S61 S61: Reorganizing files to optimize docker caching layers Dec 12, 2024
@shahdyousefak shahdyousefak linked an issue Dec 14, 2024 that may be closed by this pull request
10 tasks
@jaydeepsingh25 jaydeepsingh25 merged commit 25eccce into main Dec 16, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schemas should be loaded near the end of the build
2 participants