Shift origin of output svg in map and photo tactile handlers to (0,0) #916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TAT canvas does not shift if the SVG origin is anything besides (0,0) despite fitting to graphic height and width but the SVG output of earlier implementations of the photo/map-tactile-handler had origins at (0, -y_max). While the ideal solution would be to make the fixes to the TAT, this requires more extensive changes and potentially fixing issues that changes to SVG-Edit will fix (tracked on Shared-Reality-Lab/IMAGE-Monarch#60). Instead, the origin of the photo and map-tactile-svg-handlers have been modified to output SVGs with viewBox = "0 0 width height"
Tested for
The SVGs appear identical visually but the viewBox is different
Old:
New:
Old:
New:
Jaydeep also verified that this works as expected while integrating the TAT with the extension
Required Information
Coding/Commit Requirements
New Component Checklist (mandatory for new microservices)
docker-compose.yml
andbuild.yml
..github/workflows
.README.md
file that describes what the component does and what it depends on (other microservices, ML models, etc.).OR