Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Damage Calculator Grid Rework #1523

Merged
merged 2 commits into from
Oct 15, 2023
Merged

Damage Calculator Grid Rework #1523

merged 2 commits into from
Oct 15, 2023

Conversation

hfcRed
Copy link
Contributor

@hfcRed hfcRed commented Oct 15, 2023

I have some proposed changes for the damage calculator grid, particularly to make it more mobile friendly.

Currently you have to scroll up/down and left/right a lot, quickly loosing track of the relevant damage type and damage receiver.

opera_IQvssTQKqS

On Desktop it can also sometimes not be obvious that there is more content to the right until you scroll all the way down.

opera_wUpmjlGeG8

By sacrificing a tiny amount of space, its possible to fit all row content on Desktop.
The first row is made sticky, so the relevant information never leaves the screen.

opera_5LUR2QR5wu

On mobile the first column is also made sticky.
This way you can always see which data corresponds to which damage type and damage receiver.

opera_yUjzpJb2sK

I tried to keep all the styling as close to the original as possible, but had to cut down on a few paddings.

Let me know what you think!

@Sendouc
Copy link
Owner

Sendouc commented Oct 15, 2023

Nice contribution! You are right this works out much better :)

@Sendouc Sendouc merged commit de507e8 into Sendouc:rewrite Oct 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants