Declare minimum versions of urllib3 and requests as dependencies (#64)

SemaphoreSolutions · Aug 6, 2024 · aa4db0e · aa4db0e
1 parent 0a6c7ce
commit aa4db0e
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 Release History
 ===============
+1.6.1
+-
+- Explicitly declare requests >= 2.22.0 and urllib3 >= 1.25.2 as dependencies, which fixes an edge case causing the `lims.versions` and `lims.current_minor_version` properties to raise an exception on early versions of Python 3.6.
+
 1.6.0
 -
 - (#60) Added support for Python 3.12.

diff --git a/requirements.txt b/requirements.txt
@@ -1,10 +1,11 @@
 # Base requirements
-requests
+requests>=2.22.0
 argparse
 python-dateutil
 six>=1.12
 future
 typing;python_version<"3.5"
+urllib3>=1.25.2
 
 # Test requirements
 mock

diff --git a/s4/clarity/version.py b/s4/clarity/version.py
@@ -1,4 +1,4 @@
 # Copyright 2019 Semaphore Solutions, Inc.
 # ---------------------------------------------------------------------------
 
-__version__ = '1.6.0'
+__version__ = '1.6.1'
diff --git a/setup.py b/setup.py
@@ -43,12 +43,13 @@
         'Programming Language :: Python :: Implementation :: PyPy'
     ],
     install_requires=(
-        'requests',
+        'requests>=2.22.0',
         'argparse',
         'python-dateutil',
         'six',
         'future',
-        "typing; python_version < '3.5'"
+        "typing; python_version < '3.5'",
+        'urllib3>=1.25.2'
     ),
     tests_require=(
         'mock',