Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #7100 : [Dropdown] - allowTab tabindex value should default to select's tabindex (if exists) #7100 #7142

Open
wants to merge 14 commits into
base: next
Choose a base branch
from
Open
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
Questions about usage should be asked in our [Gitter chatroom](https://gitter.im/Semantic-Org/Semantic-UI), on [Semantic UI forums](http://forums.semantic-ui.com) or [StackOverflow](http://stackoverflow.com/questions/tagged/semantic-ui).

Examples of usage questions
* *Why isnt my code working?*
* *Why isn't my code working?*
* *Can Semantic UI do this?*

Once you receive feedback through community channels you may find your question is actually a bug. At this point it's a good idea to submit it as a bug report. Just keep in mind the following suggestions.
Expand Down
6 changes: 2 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,9 @@ Key Features

Semantic allows developers to build beautiful websites fast, with **concise HTML**, **intuitive javascript**, and **simplified debugging**, helping make front-end development a delightful experience. Semantic is responsively designed allowing your website to scale on multiple devices. Semantic is production ready and partnered with frameworks such as **React**, **Angular**, **Meteor**, and **Ember**, which means you can integrate it with any of these frameworks to organize your UI layer alongside your application logic.

## 2.4.0 Release (Sep 17th, 2018)
## 2.5.0 Release (Oct 6, 2022)

Semantic UI `2.4` is now available. Read up on [what's new](http://www.semantic-ui.com/introduction/new.html) in the docs.

Migration info from `1.x` can be found in the [2.0 release notes](https://github.com/Semantic-Org/Semantic-UI/blob/master/RELEASE-NOTES.md#version-200---march-xx-2015)
Semantic UI is now compatible with Node 18 and Gulp 4.

## User Support

Expand Down
8 changes: 4 additions & 4 deletions RELEASE-NOTES.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
## RELEASE NOTES

### Version 2.5.0 - Oct 21, 2018
### Version 2.5.0 - Oct 6, 2022

**Note**
> Special Note: If you run into any breaking changes with Gulp 4. Please reach out to me at [email protected] with bug reports

**Critical Fix**
- **CSS** - Fix extra semicolon causing CSS build of Semantic UI to fail compilation with various systems
- **CSS** - Fix extra semicolon causing CSS build of Semantic UI to fail compilation with various systems #7065 [React Issue](https://github.com/Semantic-Org/Semantic-UI-React/issues/4287) [CSS Repo Issue #81](https://github.com/Semantic-Org/Semantic-UI-CSS/issues/81) [CSS Issue #75](https://github.com/Semantic-Org/Semantic-UI-CSS/issues/75)

**Breaking Changes**
- **Gulp** - Updated all tasks to work with Gulp 4. This should fix SUI to install correctly on Node 12 or greater (see [Gulp3 Issue](https://github.com/gulpjs/gulp/issues/2324) for more details)
- **Node** - Updated scripts to build in Node 18 via vanilla install.
- **Gulp 4** -All tasks have been rewritten to work with Gulp 4. This should fix SUI to install correctly on Node 12 or greater (see [Gulp3 Issue](https://github.com/gulpjs/gulp/issues/2324) for more details)

**Build**
- **Node** - Updated scripts to build in Node 18 via vanilla install.
- **Theme** - Allow site's global site theme to be missing #6876 **Thanks @cruzdanillo**
- **Meteor** - Fix issue with misuse of `api.addAssets` #6790 **Thanks @gimco**
- **Gulp** - Report errors in build #7005 **Thanks @bundyo**
Expand Down
26 changes: 26 additions & 0 deletions dist/components/button.css
Original file line number Diff line number Diff line change
Expand Up @@ -856,6 +856,32 @@
text-align: center;
transform: translateY(-50%);
}

/* Loading */
.ui.labeled.icon.button > .icon.loading {
-webkit-animation: none;
animation: none;
}
.ui.labeled.icon.button > .icon.loading:before {
-webkit-animation: labeled-button-icon-loading 2s linear infinite;
animation: labeled-button-icon-loading 2s linear infinite;
}
@-webkit-keyframes labeled-button-icon-loading {
from {
transform: translateY(-50%) rotate(0deg);
}
to {
transform: translateY(-50%) rotate(360deg);
}
}
@keyframes labeled-button-icon-loading {
from {
transform: translateY(-50%) rotate(0deg);
}
to {
transform: translateY(-50%) rotate(360deg);
}
}
.ui.labeled.icon.buttons .button > .icon {
border-radius: 0em;
}
Expand Down
2 changes: 1 addition & 1 deletion dist/components/button.min.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/components/dimmer.js
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ $.fn.dimmer = function(parameters) {

event: {
click: function(event) {
module.verbose('Determining if event occured on dimmer', event);
module.verbose('Determining if event occurred on dimmer', event);
if( $dimmer.find(event.target).length === 0 || $(event.target).is(selector.content) ) {
module.hide();
event.stopImmediatePropagation();
Expand Down
2 changes: 1 addition & 1 deletion dist/components/dimmer.min.js

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions dist/components/icon.css
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ i.icon:before {
i.icon.loading {
height: 1em;
line-height: 1;
}
i.icon.loading {
-webkit-animation: icon-loading 2s linear infinite;
animation: icon-loading 2s linear infinite;
}
Expand Down
2 changes: 1 addition & 1 deletion dist/components/icon.min.css

Large diffs are not rendered by default.

35 changes: 35 additions & 0 deletions dist/semantic.css
Original file line number Diff line number Diff line change
Expand Up @@ -1719,6 +1719,38 @@ body .ui.inverted::-webkit-scrollbar-thumb:hover {
transform: translateY(-50%);
}

/* Loading */

.ui.labeled.icon.button > .icon.loading {
-webkit-animation: none;
animation: none;
}

.ui.labeled.icon.button > .icon.loading:before {
-webkit-animation: labeled-button-icon-loading 2s linear infinite;
animation: labeled-button-icon-loading 2s linear infinite;
}

@-webkit-keyframes labeled-button-icon-loading {
from {
transform: translateY(-50%) rotate(0deg);
}

to {
transform: translateY(-50%) rotate(360deg);
}
}

@keyframes labeled-button-icon-loading {
from {
transform: translateY(-50%) rotate(0deg);
}

to {
transform: translateY(-50%) rotate(360deg);
}
}

.ui.labeled.icon.buttons .button > .icon {
border-radius: 0em;
}
Expand Down Expand Up @@ -7399,6 +7431,9 @@ i.icon:before {
i.icon.loading {
height: 1em;
line-height: 1;
}

i.icon.loading {
-webkit-animation: icon-loading 2s linear infinite;
animation: icon-loading 2s linear infinite;
}
Expand Down
2 changes: 1 addition & 1 deletion dist/semantic.js
Original file line number Diff line number Diff line change
Expand Up @@ -3802,7 +3802,7 @@ $.fn.dimmer = function(parameters) {

event: {
click: function(event) {
module.verbose('Determining if event occured on dimmer', event);
module.verbose('Determining if event occurred on dimmer', event);
if( $dimmer.find(event.target).length === 0 || $(event.target).is(selector.content) ) {
module.hide();
event.stopImmediatePropagation();
Expand Down
4 changes: 2 additions & 2 deletions dist/semantic.min.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/semantic.min.js

Large diffs are not rendered by default.

Loading