Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added suggestions #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

paramnayar
Copy link

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

@@ -8,6 +8,9 @@
import os
import platform
import shutil
import pandas as pd
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this library necessary?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code is the bomb


Sema Reaction: 👌 This code looks good | Sema Tags: Elegant, Fault-tolerant

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use object method shorthand. eslint: object-shorthand


Sema Reaction: 🛠️ This code needs a fix | Sema Tags: Not reusable, Brittle, Not maintainable

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but not sure about a vs b?

__
sema-logo  Summary: ❓ I have a question

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for test

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic should in general be asking the question "Is this true?" instead of "Is this not true?"

📄 Principles.dev

__
sema-logo  Summary: 🛠️ This code needs a fix  |  Tags: Secure, Inelegant

Copy link
Author

@paramnayar paramnayar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question whether new library is needed

@SemaQAAutomationAdmin
Copy link

A UI function for a security feature appears to be supported and gives feedback to the user that suggests that it is supported, but the underlying functionality is not implemented.

📄 Mitre
FOR TEST

__
sema-logo  Summary: 🛠️ This code needs a fix

@yanakovrygina
Copy link

Almost all Ruby programmers use each instead of a for when iterating through a collection. It is simply more readable.
TEST
📄 Sitepoint

__
sema-logo  Summary: 🛠️ This code needs a fix  |  Tags: Unreadable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants