-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added suggestions #1
base: main
Are you sure you want to change the base?
Conversation
@@ -8,6 +8,9 @@ | |||
import os | |||
import platform | |||
import shutil | |||
import pandas as pd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this library necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this code is the bomb
Sema Reaction: 👌 This code looks good | Sema Tags: Elegant, Fault-tolerant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use object method shorthand. eslint: object-shorthand
Sema Reaction: 🛠️ This code needs a fix | Sema Tags: Not reusable, Brittle, Not maintainable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question whether new library is needed
A UI function for a security feature appears to be supported and gives feedback to the user that suggests that it is supported, but the underlying functionality is not implemented. 📄 Mitre |
Almost all Ruby programmers use each instead of a for when iterating through a collection. It is simply more readable. |
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?