-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] do not enable CDP deprecation warning if BiDi enabled #15170
Conversation
This reverts commit f17dd08dd32998a310510f0abc44e5b484202a4d.
This reverts commit cc16e3f. oops
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
aaef595
to
1c1cb80
Compare
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Fixes #11736 (comment)
Motivation and Context
It adds if BiDi is enabled then do not show the CDP warning.
Types of changes
Checklist
PR Type
Enhancement, Bug fix
Description
Suppress CDP deprecation warning if BiDi is enabled.
Adjusted logic for Firefox CDP deprecation warnings.
Improved compatibility with WebDriver BiDi protocol.
Changes walkthrough 📝
CdpEndpointFinder.java
Adjust CDP deprecation warning logic for Firefox
java/src/org/openqa/selenium/devtools/CdpEndpointFinder.java
webSocketUrl
is enabled.FirefoxDriver.java
Update FirefoxDriver to respect BiDi capability
java/src/org/openqa/selenium/firefox/FirefoxDriver.java
webSocketUrl
capability.