-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java][bidi]: implement bidi setCacheBehavior
#15130
[java][bidi]: implement bidi setCacheBehavior
#15130
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
java/src/org/openqa/selenium/bidi/network/SetCacheBehaviorParameters.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! @navin772 LGTM
The CI failures are not relevant to the changes done in this PR. |
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
This PR adds the bidi method
setCacheBehavior
defined in the bidi specs - https://w3c.github.io/webdriver-bidi/#command-network-setCacheBehavior.I have verified that this works with the latest stable Firefox 134 and Chrome 132.
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement, Tests
Description
Implemented the BiDi
setCacheBehavior
method for Java bindings.Added
CacheBehavior
enum andSetCacheBehaviorParameters
class.Developed unit tests for
setCacheBehavior
functionality.Enhanced network module to support cache behavior configuration.
Changes walkthrough 📝
Network.java
Add `setCacheBehavior` method to Network module
java/src/org/openqa/selenium/bidi/module/Network.java
setCacheBehavior
method to theNetwork
class.SetCacheBehaviorParameters
for cache behaviorconfiguration.
CacheBehavior.java
Introduce `CacheBehavior` enum for cache settings
java/src/org/openqa/selenium/bidi/network/CacheBehavior.java
CacheBehavior
enum to define cache behavior options.DEFAULT
andBYPASS
cache behavior types.SetCacheBehaviorParameters.java
Add `SetCacheBehaviorParameters` for cache configuration
java/src/org/openqa/selenium/bidi/network/SetCacheBehaviorParameters.java
SetCacheBehaviorParameters
class for cache behaviorconfiguration.
toMap
method for parameter serialization.NetworkCommandsTest.java
Add tests for `setCacheBehavior` in Network module
java/test/org/openqa/selenium/bidi/network/NetworkCommandsTest.java
setCacheBehavior
functionality.BYPASS
andDEFAULT
cache behaviors with and without contextIDs.