Merge branch 'trunk' into pallavi-getCookieRuby

Rakefile

@@ -1126,7 +1126,7 @@ namespace :all do
 end
 
 at_exit do
-  system 'sh', '.git-fixfiles' if File.exist?('.git') && !SeleniumRake::Checks.windows?
+  system 'sh', '.git-fixfiles' if File.exist?('.git') && SeleniumRake::Checks.linux?
 end
 
 def updated_version(current, desired = nil, nightly = nil)

common/mirror/selenium

@@ -1,15 +1,35 @@
 [
+  {
+    "tag_name": "selenium-4.28.0",
+    "assets": [
+      {
+        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.28.0/selenium-dotnet-4.28.0.zip"
+      },
+      {
+        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.28.0/selenium-dotnet-strongnamed-4.28.0.zip"
+      },
+      {
+        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.28.0/selenium-java-4.28.0.zip"
+      },
+      {
+        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.28.0/selenium-server-4.28.0.jar"
+      },
+      {
+        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.28.0/selenium-server-4.28.0.zip"
+      }
+    ]
+  },
   {
     "tag_name": "nightly",
     "assets": [
       {
-        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/nightly/selenium-java-4.28.0-SNAPSHOT.zip"
+        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/nightly/selenium-java-4.29.0-SNAPSHOT.zip"
       },
       {
-        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/nightly/selenium-server-4.28.0-SNAPSHOT.jar"
+        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/nightly/selenium-server-4.29.0-SNAPSHOT.jar"
       },
       {
-        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/nightly/selenium-server-4.28.0-SNAPSHOT.zip"
+        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/nightly/selenium-server-4.29.0-SNAPSHOT.zip"
       }
     ]
   },
@@ -929,28 +949,5 @@
         "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.0.0/selenium-server-4.0.0.zip"
       }
     ]
-  },
-  {
-    "tag_name": "selenium-4.0.0-rc-3",
-    "assets": [
-      {
-        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.0.0-rc-3/selenium-dotnet-4.0.0-rc3.zip"
-      },
-      {
-        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.0.0-rc-3/selenium-dotnet-strongnamed-4.0.0-rc3.zip"
-      },
-      {
-        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.0.0-rc-3/selenium-html-runner-4.0.0-rc-3.jar"
-      },
-      {
-        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.0.0-rc-3/selenium-java-4.0.0-rc-3.zip"
-      },
-      {
-        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.0.0-rc-3/selenium-server-4.0.0-rc-3.jar"
-      },
-      {
-        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.0.0-rc-3/selenium-server-4.0.0-rc-3.zip"
-      }
-    ]
   }
 ]

dotnet/docs/index.md

@@ -5,5 +5,5 @@ layout: landingPage
 # Welcome to the Selenium .NET API Docs
 
 ## Modules
-- [Selenium.WebDriver](/webdriver/OpenQA.Selenium.html)
-- [Selenium.Support](/support/OpenQA.Selenium.Support.html)
+- [Selenium.WebDriver](webdriver/OpenQA.Selenium.html)
+- [Selenium.Support](support/OpenQA.Selenium.Support.html)

dotnet/selenium-dotnet-version.bzl

@@ -1,6 +1,6 @@
 # BUILD FILE SYNTAX: STARLARK
 
-SE_VERSION = "4.28.0"
+SE_VERSION = "4.29.0-nightly202501201850"
 ASSEMBLY_VERSION = "4.0.0.0"
 SUPPORTED_NET_STANDARD_VERSIONS = ["netstandard2.0"]
 

java/src/org/openqa/selenium/chrome/ChromeDriverService.java

@@ -284,7 +284,7 @@ protected void loadSystemProperties() {
     @Override
     protected List<String> createArgs() {
       List<String> args = new ArrayList<>();
-      args.add(String.format("--port=%d", getPort()));
+      args.add(String.format(Locale.ROOT, "--port=%d", getPort()));
 
       // Readable timestamp and append logs only work if log path is specified in args
       // Cannot use logOutput because goog:loggingPrefs requires --log-path get sent

java/src/org/openqa/selenium/edge/EdgeDriverService.java

@@ -278,7 +278,7 @@ protected void loadSystemProperties() {
     @Override
     protected List<String> createArgs() {
       List<String> args = new ArrayList<>();
-      args.add(String.format("--port=%d", getPort()));
+      args.add(String.format(Locale.ROOT, "--port=%d", getPort()));
 
       // Readable timestamp and append logs only work if log path is specified in args
       // Cannot use logOutput because goog:loggingPrefs requires --log-path get sent

java/src/org/openqa/selenium/firefox/GeckoDriverService.java

@@ -30,6 +30,7 @@
 import java.util.Arrays;
 import java.util.HashMap;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import org.openqa.selenium.Capabilities;
 import org.openqa.selenium.WebDriverException;
@@ -219,7 +220,7 @@ protected void loadSystemProperties() {
     @Override
     protected List<String> createArgs() {
       List<String> args = new ArrayList<>();
-      args.add(String.format("--port=%d", getPort()));
+      args.add(String.format(Locale.ROOT, "--port=%d", getPort()));
 
       int wsPort = PortProber.findFreePort();
       args.add(String.format("--websocket-port=%d", wsPort));

java/src/org/openqa/selenium/ie/InternetExplorerDriverService.java

@@ -28,6 +28,7 @@
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import org.openqa.selenium.Capabilities;
 import org.openqa.selenium.WebDriverException;
@@ -217,7 +218,7 @@ protected void loadSystemProperties() {
     @Override
     protected List<String> createArgs() {
       List<String> args = new ArrayList<>();
-      args.add(String.format("--port=%d", getPort()));
+      args.add(String.format(Locale.ROOT, "--port=%d", getPort()));
 
       if (logLevel != null) {
         args.add(String.format("--log-level=%s", logLevel));

java/src/org/openqa/selenium/remote/service/DriverService.java

@@ -138,7 +138,7 @@ protected Map<String, String> getEnvironment() {
   }
 
   protected URL getUrl(int port) throws IOException {
-    return new URL(String.format("http://localhost:%d", port));
+    return new URL(String.format(Locale.ROOT, "http://localhost:%d", port));
   }
 
   protected Capabilities getDefaultDriverOptions() {
@@ -505,17 +505,6 @@ public DS build() {
         port = PortProber.findFreePort();
       }
 
-      if (Locale.getDefault(Locale.Category.FORMAT).getLanguage().equals("ar")) {
-        throw new NumberFormatException(
-            String.format(
-                "Couldn't format the port numbers because the System Language is arabic: \""
-                    + String.format("--port=%d", port)
-                    + "\", please make sure to add the required arguments \"-Duser.language=en"
-                    + " -Duser.region=US\" to your JVM, for more info please visit :\n"
-                    + "  https://www.selenium.dev/documentation/webdriver/browsers/",
-                getPort()));
-      }
-
       if (timeout == null) {
         timeout = getDefaultTimeout();
       }

java/test/org/openqa/selenium/chrome/ChromeDriverFunctionalTest.java

@@ -204,23 +204,20 @@ void canExecuteCdpCommands() {
 
   @Test
   @NoDriverBeforeTest
-  void shouldThrowNumberFormatException() {
-    Locale arabicLocale = new Locale("ar", "EG");
-    Locale.setDefault(arabicLocale);
-
-    int port = PortProber.findFreePort();
-    ChromeDriverService.Builder builder = new ChromeDriverService.Builder();
-    builder.usingPort(port);
-
-    assertThatExceptionOfType(NumberFormatException.class)
-        .isThrownBy(builder::build)
-        .withMessage(
-            "Couldn't format the port numbers because the System Language is arabic: \""
-                + String.format("--port=%d", port)
-                + "\", please make sure to add the required arguments \"-Duser.language=en"
-                + " -Duser.region=US\" to your JVM, for more info please visit :\n"
-                + "  https://www.selenium.dev/documentation/webdriver/browsers/");
-
-    Locale.setDefault(Locale.US);
+  void shouldLaunchSuccessfullyWithArabicDate() {
+    try {
+      Locale arabicLocale = new Locale("ar", "EG");
+      Locale.setDefault(arabicLocale);
+
+      int port = PortProber.findFreePort();
+      ChromeDriverService.Builder builder = new ChromeDriverService.Builder();
+      builder.usingPort(port);
+      builder.build();
+
+    } catch (Exception e) {
+      throw e;
+    } finally {
+      Locale.setDefault(Locale.US);
+    }
   }
 }

java/test/org/openqa/selenium/edge/EdgeDriverFunctionalTest.java

@@ -198,23 +198,20 @@ void canExecuteCdpCommands() {
 
   @Test
   @NoDriverBeforeTest
-  void shouldThrowNumberFormatException() {
-    Locale arabicLocale = new Locale("ar", "EG");
-    Locale.setDefault(arabicLocale);
-
-    int port = PortProber.findFreePort();
-    EdgeDriverService.Builder builder = new EdgeDriverService.Builder();
-    builder.usingPort(port);
-
-    assertThatExceptionOfType(NumberFormatException.class)
-        .isThrownBy(builder::build)
-        .withMessage(
-            "Couldn't format the port numbers because the System Language is arabic: \""
-                + String.format("--port=%d", port)
-                + "\", please make sure to add the required arguments \"-Duser.language=en"
-                + " -Duser.region=US\" to your JVM, for more info please visit :\n"
-                + "  https://www.selenium.dev/documentation/webdriver/browsers/");
-
-    Locale.setDefault(Locale.US);
+  void shouldLaunchSuccessfullyWithArabicDate() {
+    try {
+      Locale arabicLocale = new Locale("ar", "EG");
+      Locale.setDefault(arabicLocale);
+
+      int port = PortProber.findFreePort();
+      EdgeDriverService.Builder builder = new EdgeDriverService.Builder();
+      builder.usingPort(port);
+      builder.build();
+
+    } catch (Exception e) {
+      throw e;
+    } finally {
+      Locale.setDefault(Locale.US);
+    }
   }
 }

java/test/org/openqa/selenium/firefox/FirefoxDriverTest.java

@@ -18,7 +18,6 @@
 package org.openqa.selenium.firefox;
 
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.assertj.core.api.AssertionsForClassTypes.assertThatExceptionOfType;
 import static org.assertj.core.api.AssertionsForClassTypes.assertThatThrownBy;
 import static org.junit.jupiter.api.Assertions.fail;
 import static org.junit.jupiter.api.Assumptions.assumeTrue;
@@ -273,24 +272,21 @@ void canSetContext() {
 
   @Test
   @NoDriverBeforeTest
-  void shouldThrowNumberFormatException() {
-    Locale arabicLocale = new Locale("ar", "EG");
-    Locale.setDefault(arabicLocale);
-
-    int port = PortProber.findFreePort();
-    GeckoDriverService.Builder builder = new GeckoDriverService.Builder();
-    builder.usingPort(port);
-
-    assertThatExceptionOfType(NumberFormatException.class)
-        .isThrownBy(builder::build)
-        .withMessage(
-            "Couldn't format the port numbers because the System Language is arabic: \""
-                + String.format("--port=%d", port)
-                + "\", please make sure to add the required arguments \"-Duser.language=en"
-                + " -Duser.region=US\" to your JVM, for more info please visit :\n"
-                + "  https://www.selenium.dev/documentation/webdriver/browsers/");
-
-    Locale.setDefault(Locale.US);
+  void shouldLaunchSuccessfullyWithArabicDate() {
+    try {
+      Locale arabicLocale = new Locale("ar", "EG");
+      Locale.setDefault(arabicLocale);
+
+      int port = PortProber.findFreePort();
+      GeckoDriverService.Builder builder = new GeckoDriverService.Builder();
+      builder.usingPort(port);
+      builder.build();
+
+    } catch (Exception e) {
+      throw e;
+    } finally {
+      Locale.setDefault(Locale.US);
+    }
   }
 
   private static class CustomFirefoxProfile extends FirefoxProfile {}

java/test/org/openqa/selenium/ie/InternetExplorerDriverTest.java

@@ -147,24 +147,21 @@ void testPersistentHoverCanBeTurnedOff() throws Exception {
 
   @Test
   @NoDriverBeforeTest
-  void shouldThrowNumberFormatException() {
-    Locale arabicLocale = new Locale("ar", "EG");
-    Locale.setDefault(arabicLocale);
+  void shouldLaunchSuccessfullyWithArabicDate() {
+    try {
+      Locale arabicLocale = new Locale("ar", "EG");
+      Locale.setDefault(arabicLocale);
 
-    int port = PortProber.findFreePort();
-    InternetExplorerDriverService.Builder builder = new InternetExplorerDriverService.Builder();
-    builder.usingPort(port);
+      int port = PortProber.findFreePort();
+      InternetExplorerDriverService.Builder builder = new InternetExplorerDriverService.Builder();
+      builder.usingPort(port);
+      builder.build();
 
-    assertThatExceptionOfType(NumberFormatException.class)
-        .isThrownBy(builder::build)
-        .withMessage(
-            "Couldn't format the port numbers because the System Language is arabic: \""
-                + String.format("--port=%d", port)
-                + "\", please make sure to add the required arguments \"-Duser.language=en"
-                + " -Duser.region=US\" to your JVM, for more info please visit :\n"
-                + "  https://www.selenium.dev/documentation/webdriver/browsers/");
-
-    Locale.setDefault(Locale.US);
+    } catch (Exception e) {
+      throw e;
+    } finally {
+      Locale.setDefault(Locale.US);
+    }
   }
 
   private WebDriver newIeDriver() {

java/test/org/openqa/selenium/safari/SafariDriverTest.java

@@ -137,23 +137,20 @@ public void canAttachDebugger() {
 
   @Test
   @NoDriverBeforeTest
-  void shouldThrowNumberFormatException() {
-    Locale arabicLocale = new Locale("ar", "EG");
-    Locale.setDefault(arabicLocale);
-
-    int port = PortProber.findFreePort();
-    SafariDriverService.Builder builder = new SafariDriverService.Builder();
-    builder.usingPort(port);
-
-    assertThatExceptionOfType(NumberFormatException.class)
-        .isThrownBy(builder::build)
-        .withMessage(
-            "Couldn't format the port numbers because the System Language is arabic: \""
-                + String.format("--port=%d", port)
-                + "\", please make sure to add the required arguments \"-Duser.language=en"
-                + " -Duser.region=US\" to your JVM, for more info please visit :\n"
-                + "  https://www.selenium.dev/documentation/webdriver/browsers/");
-
-    Locale.setDefault(Locale.US);
+  void shouldLaunchSuccessfullyWithArabicDate() {
+    try {
+      Locale arabicLocale = new Locale("ar", "EG");
+      Locale.setDefault(arabicLocale);
+
+      int port = PortProber.findFreePort();
+      SafariDriverService.Builder builder = new SafariDriverService.Builder();
+      builder.usingPort(port);
+      builder.build();
+
+    } catch (Exception e) {
+      throw e;
+    } finally {
+      Locale.setDefault(Locale.US);
+    }
   }
 }

java/version.bzl

@@ -1,2 +1,2 @@
-SE_VERSION = "4.28.0"
+SE_VERSION = "4.29.0-SNAPSHOT"
 TOOLS_JAVA_VERSION = "17"

javascript/node/selenium-webdriver/BUILD.bazel

@@ -11,7 +11,7 @@ load("//javascript/private:browsers.bzl", "BROWSERS")
 
 npm_link_all_packages(name = "node_modules")
 
-VERSION = "4.28.0"
+VERSION = "4.29.0-nightly202501202154"
 
 BROWSER_VERSIONS = [
     "v85",

javascript/node/selenium-webdriver/CHANGES.md

@@ -1,3 +1,7 @@
+## 4.28.1
+
+- [JS] specify min required node versiton to 18.20.5
+
 ## 4.28.0
 
 - Add CDP for Chrome 132 and remove 129