Skip to content

Commit

Permalink
fix(modelgateway): kafka topics with correct number of partitions (#5427
Browse files Browse the repository at this point in the history
)

The number of partitions with which model-specific kafka topics
is created needs to be the same as the number of partitions for
other topics (pipelines/experiments/etc). This is a Kafka Streams
constraint in order for joins to work correctly.

Until now, an incorrect environment variable was being passed to
modelgateway, which meant that it was always creating topics with
1 partition. This in turn led to dataflow processing getting stuck
whenever other topics were created with multiple partitions

**Fixed issues**:
- INFRA-822: Pipelines get stuck on triggers/joins
  • Loading branch information
lc525 authored Mar 12, 2024
1 parent b1d3890 commit bdeba06
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1163,7 +1163,7 @@ spec:
value: '{{ .Values.modelgateway.workers }}'
- name: KAFKA_DEFAULT_REPLICATION_FACTOR
value: '{{ .Values.kafka.topics.replicationFactor }}'
- name: KAFKA_DEFAULT_PARTITIONS_DEFAULT
- name: KAFKA_DEFAULT_NUM_PARTITIONS
value: '{{ .Values.kafka.topics.numPartitions }}'
- name: CONTROL_PLANE_SECURITY_PROTOCOL
value: '{{ .Values.security.controlplane.protocol }}'
Expand Down
2 changes: 1 addition & 1 deletion k8s/helm-charts/seldon-core-v2-setup/values.yaml.template
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ serverConfig:
pullPolicy: IfNotPresent
registry: docker.io
repository: seldonio/mlserver
tag: 1.3.5
tag: 1.5.0
serverCapabilities: "mlserver,alibi-detect,alibi-explain,huggingface,lightgbm,mlflow,python,sklearn,spark-mlib,xgboost"
modelVolumeStorage: 1Gi
resources:
Expand Down
2 changes: 1 addition & 1 deletion k8s/kustomize/helm-components-sc/patch_modelgateway.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
value: '{{ .Values.modelgateway.workers }}'
- name: KAFKA_DEFAULT_REPLICATION_FACTOR
value: '{{ .Values.kafka.topics.replicationFactor }}'
- name: KAFKA_DEFAULT_PARTITIONS_DEFAULT
- name: KAFKA_DEFAULT_NUM_PARTITIONS
value: '{{ .Values.kafka.topics.numPartitions }}'
- name: CONTROL_PLANE_SECURITY_PROTOCOL
value: '{{ .Values.security.controlplane.protocol }}'
Expand Down
2 changes: 1 addition & 1 deletion k8s/yaml/components.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,7 @@ spec:
value: '8'
- name: KAFKA_DEFAULT_REPLICATION_FACTOR
value: '1'
- name: KAFKA_DEFAULT_PARTITIONS_DEFAULT
- name: KAFKA_DEFAULT_NUM_PARTITIONS
value: '1'
- name: CONTROL_PLANE_SECURITY_PROTOCOL
value: 'PLAINTEXT'
Expand Down

0 comments on commit bdeba06

Please sign in to comment.