add todo note

SeldonIO · Jan 28, 2025 · 6170cdf · 6170cdf
1 parent 0d73987
commit 6170cdf
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/scheduler/pkg/store/memory.go b/scheduler/pkg/store/memory.go
@@ -379,6 +379,8 @@ func (m *MemoryStore) updateLoadedModelsImpl(
 
 	// note that we use len(modelVersion.GetAssignment()) to calculate the number of replicas as the status of the model at this point might not reflect the actual number of replicas
 	// in modelVersion.state.AvailableReplicas (we call updateModelStatus later)
+
+	// TODO: the conditions here keep growing, refactor or consider a simpler check.
 	if replicaStateUpdated || modelVersion.state.State == ScheduleFailed || model.IsDeleted() || modelVersion.state.State == ModelProgressing ||
 		(modelVersion.state.State == ModelAvailable && len(modelVersion.GetAssignment()) < modelVersion.DesiredReplicas()) {
 		logger.Debugf("Updating model status for model %s server %s", modelKey, serverKey)