Fix warnings that will be treated as errors in CMSSW #367
Conversation
|
/run standalone |
|
The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.
The full set of validation and comparison plots can be found here. |
| int* nMDs; //counter per module | ||
| int* totOccupancyMDs; //counter per module | ||
| unsigned int* nMDs; //counter per module | ||
| unsigned int* totOccupancyMDs; //counter per module |
There was a problem hiding this comment.
I was thinking if it's more practical to switch to explicit size integer types.
like int32_t and uint32_t
There was a problem hiding this comment.
I was thinking if it's more practical to switch to explicit size integer types.
this is outside of this PR scope
There was a problem hiding this comment.
that's true, I'll think about how much work that would be
|
@ariostas |
|
/run standalone |
|
The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.
The full set of validation and comparison plots can be found here. |
I fixed a bunch of warnings that are treated as errors in CMSSW by default. The main thing was fixing comparisons between signed and unsigned integers. I changed some variable to be unsigned integers, since it makes more sense for them to be unsigned. I also had to remove a bunch of unused variables. I was undecided between deleting the lines or commenting them out. I decided on deleting them since they looked like remnants from old code.
I also removed the dependency on cppitertools, which was a very minor change that I don't think necessitates its own PR.
There are still a lot of warnings remaining. I think it is definitely worth taking a look at them since some of them look important. However, this PR is already somewhat lengthy, so maybe I'll do that in a later PR.
Also, I noticed that there is a lot of repeated code. I think that it would be worth doing some refactoring at some point to make things more modular.