Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute Orientations from CSV #10

Merged
merged 6 commits into from
Mar 17, 2024
Merged

Compute Orientations from CSV #10

merged 6 commits into from
Mar 17, 2024

Conversation

GNiendorf
Copy link
Member

@GNiendorf GNiendorf commented Feb 21, 2024 •
edited
Loading

This PR introduces a compute_orientation.py file which outputs two orientation files used by the segment linking algorithm.

Corresponding PR on the Tracklooper repository is here: SegmentLinking/TrackLooper#374

@GNiendorf GNiendorf marked this pull request as ready for review February 21, 2024 16:29
@GNiendorf GNiendorf requested a review from VourMa February 21, 2024 16:29
@GNiendorf
Copy link
Member Author

GNiendorf commented Feb 21, 2024 •
edited
Loading

@VourMa This PR is ready for review, but let's merge it in alongside a separate PR I'm going to make in the main repo so that everything is aligned properly.

@GNiendorf GNiendorf mentioned this pull request Mar 7, 2024
Merged
@GNiendorf
Copy link
Member Author

GNiendorf commented Mar 9, 2024 •
edited
Loading

I'm going to add one more commit tomorrow that updates the README usage info. I'm also going to add the output format for each file so that people don't have to dig through the code to understand the numbers in each output file.

Edit: Just added the commit, I'll stop making commits now until this PR is reviewed.

@GNiendorf
Copy link
Member Author

@VourMa The two PR's are done btw, when you get a chance can you review them? Thank you!

VourMa
VourMa reviewed Mar 13, 2024
View reviewed changes
Copy link
Contributor

@VourMa VourMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks ok, I left just some minor, optional comments to consider for clarifications and/or for potential small improvements.

@GNiendorf
Copy link
Member Author

I think this PR is ready to be merged if you have no comments on my last commit @VourMa. I checked that there are no changes in the maps.

VourMa
VourMa approved these changes Mar 17, 2024
View reviewed changes
Copy link
Contributor

@VourMa VourMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes, @GNiendorf. Approving and merging!

@VourMa VourMa merged commit f303014 into master Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VourMa VourMa VourMa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GNiendorf @VourMa