This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
Fix for inconsistent values from nativeEvent.offsetX and Y #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…because offset gives layout size and bounding rect gives render size
|
Thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was exploring a change to address issue #14 and ran into an issue with the selector that was caused by the use of offsetX and offsetY in getCoordPercentage.
MouseEvent offsets give inconsistent results when dragging up and to the left rather than the more natural down and to the right. The reason could be browser implementation (it is still experimental) or it could be that nativeEvent offsets are based on target rather than currentTarget, I don't know.
To keep consistent behavior with the selector use the bounding client rect to calculate offset values for the current element.