Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint #77

Merged
merged 1 commit into from
Feb 5, 2025
Merged

lint #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/unit_tests/src/analytics_plugin_ut.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,10 +211,9 @@
{
ASSERT_TRUE(event);

NX_PRINT << "EngineHandler: Received a plugin diagnostic event: "
<< "level " << (int)event->level() << ", "
<< "caption " << nx::kit::utils::toString(event->caption()) << ", "
<< "description " << nx::kit::utils::toString(event->description());
NX_PRINT << "EngineHandler: Received a plugin diagnostic event: " << "level " << (int)event->level() << ", "
<< "caption " << nx::kit::utils::toString(event->caption()) << ", " << "description "
<< nx::kit::utils::toString(event->description());
}

virtual void pushManifest(const IString *manifest) override
Expand All @@ -233,10 +232,9 @@
{
ASSERT_TRUE(event);

NX_PRINT << "EngineHandler: Received a plugin diagnostic event: "
<< "level " << (int)event->level() << ", "
<< "caption " << nx::kit::utils::toString(event->caption()) << ", "
<< "description " << nx::kit::utils::toString(event->description());
NX_PRINT << "EngineHandler: Received a plugin diagnostic event: " << "level " << (int)event->level() << ", "
<< "caption " << nx::kit::utils::toString(event->caption()) << ", " << "description "
<< nx::kit::utils::toString(event->description());
}
};

Expand Down Expand Up @@ -305,11 +303,11 @@
{
return "";
}
virtual IString *cloudSystemId() const

Check warning on line 306 in src/unit_tests/src/analytics_plugin_ut.cpp

View workflow job for this annotation

GitHub Actions / build (ubuntu-22.04, Release, clang) 

'cloudSystemId' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Check warning on line 306 in src/unit_tests/src/analytics_plugin_ut.cpp

View workflow job for this annotation

GitHub Actions / build (ubuntu-22.04, Release, clang) 

'cloudSystemId' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Check warning on line 306 in src/unit_tests/src/analytics_plugin_ut.cpp

View workflow job for this annotation

GitHub Actions / build (ubuntu-20.04, Release, clang) 

'cloudSystemId' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
{
return new nx::sdk::String();
}
virtual IString *cloudAuthKey() const

Check warning on line 310 in src/unit_tests/src/analytics_plugin_ut.cpp

View workflow job for this annotation

GitHub Actions / build (ubuntu-22.04, Release, clang) 

'cloudAuthKey' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Check warning on line 310 in src/unit_tests/src/analytics_plugin_ut.cpp

View workflow job for this annotation

GitHub Actions / build (ubuntu-22.04, Release, clang) 

'cloudAuthKey' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Check warning on line 310 in src/unit_tests/src/analytics_plugin_ut.cpp

View workflow job for this annotation

GitHub Actions / build (ubuntu-20.04, Release, clang) 

'cloudAuthKey' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
{
return new nx::sdk::String();
}
Expand Down
Loading